fix(Form): loses focus on submit #3796
Open
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
romhml
reviewed
Apr 4, 2025
src/runtime/components/Form.vue
Outdated
| @@ -231,6 +232,7 @@ async function onSubmitWrapper(payload: Event) { | |||
| emits('error', errorEvent) | |||
| } finally { | |||
| loading.value = false | |||
| setTimeout(() => activeElement?.focus(), 0) | |||
There was a problem hiding this comment.
I'm not confortable with this setTimeout, I think we might be better off introducing a props like the button component loadingAuto to allow users to disable the automatic loading / disabled state.
|
I have added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Resolves #3786
❓ Type of change
📚 Description
When submitting a form, the loading state disables the inputs causing the lose of focus, so this save the activeElement before updating the loading status and restoring the focus at the end of submit.
I was between this solution and stop disabling the inputs on loading state.
📝 Checklist