-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(portal): add configurable portalTarget
support
#3688
base: v3
Are you sure you want to change the base?
Conversation
commit: |
0d6145e
to
11d2cdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I would put this config in global app.config
but instead put it in the portal
prop of each component as an object with the to
and disabled
fields. It would be more consistent and would allow configuration per component.
I've tried, and Implementing a system using a component-based configuration proved to be significantly more challenging than anticipated. The process required meticulous definition of the target for each individual component, leading to a highly time-consuming and cumbersome configuration process. This level of detail, while potentially offering great flexibility, introduces a substantial overhead. A potential solution to mitigate this complexity might involve a hybrid approach: employing a global configuration file to establish baseline settings, while allowing for component-specific overrides where necessary. This would reduce the repetitive nature of defining targets for every component, simplifying the overall configuration management. |
Then I would still not put it in App Config but as a prop on |
This is a great idea. |
2d6b07a
to
566e49b
Compare
Is this the direction you had in mind? |
170b6fe
to
9131e60
Compare
Introduced a `portalTarget` option in `UApp` to specify portal mounting targets across various components. Updated portals in components like `ContextMenu`, `Drawer`, `Tooltip`, and others to respect `portalTarget`. Default target is set to `body`.
π Linked issue
Resolves #3687
β Type of change
π Description
Introduced a
portalTarget
option inUApp
to specify portal mounting targets across various components. Updated portals in components likeContextMenu
,Drawer
,Tooltip
, and others to respectportalTarget
. Default target is set tobody
.π Checklist