fix(dev,preview): correctly infer .env filename from --dotenv arg
#381
+40
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
danielroe
reviewed
Apr 29, 2024
DamianGlowala
changed the title
--dotenv arg--dotenv arg
|
Open in Stackblitz • nuxt-cli-playground commit: |
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
DamianGlowala
changed the title
--dotenv arg.env filename from --dotenv arg
danielroe
reviewed
Jan 13, 2025
Comment on lines
+105
to
+106
| logger.error(`Cannot find \`${envFileName}\`.`) | ||
| process.exit(1) |
There was a problem hiding this comment.
should we just warn in this case?
danielroe
reviewed
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #360
This corrects types for the
--dotenvflag and sets the default value at source.