fix: readd vue-tempate-compilation plugin #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… playgound, to solve out-of-memory issues, while resolving vue alias.
✅ Deploy Preview for nuxt-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tobiasdiez
changed the title
tobiasdiez
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Fixes #808 and fixes #805.
📚 Description
This PR reverts #740 that removes of the vue-templation-template plugin, which was initially extended from the vue3-vite project vite config. However, removing it only masked the memory issue rather than addressing its root cause—the resolution of the vue ESM bundler alias.
The vue-templation-template plugin is essential for rendering stories with custom string templates, so we need to retain it.
To work around the memory issue and ensure template compilation works correctly, i have added vue as a dependency in the root project. ( playground )
The underlying problem appears to be related to how the vue alias is resolved. When it isn’t found in the root project, some unusual string replacement occurs, leading to recursive paths and the memory issue. Further investigation may be needed to fully understand why vue cannot be resolved from sub-packages.