Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(db): support Nitro useDatabase() #15

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

feat(db): support Nitro useDatabase() #15

wants to merge 9 commits into from

Conversation

atinux
Copy link
Contributor

@atinux atinux commented Mar 7, 2024 •
edited
Loading

Resolves #2

Waiting for nitrojs/nitro#2228 to be released.

This will allow to use useDatabase() with no configuration 🚀

@atinux atinux added upstream enhancement New feature or request labels Mar 7, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Mar 9, 2024 •
edited
Loading

Deploying nuxthub-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3924719
Status: ✅  Deploy successful!
Preview URL: https://ca9761f8.nuxthub-module.pages.dev

View logs

@atinux atinux marked this pull request as ready for review March 9, 2024 16:48
@atinux atinux removed the upstream label Mar 18, 2024
@cpreston321
Copy link

Any update on this? @atinux ?

@atinux
Copy link
Contributor Author

atinux commented Apr 10, 2024

Actually I need to change it @cpreston321 to only enable it if nitro.experimental.database is set to true.

After discussing with @pi0, NuxtHub should not set experimental feature on behalf of the user.

@sandros94
Copy link
Contributor

After discussing with @pi0, NuxtHub should not set experimental feature on behalf of the user.

I also agree.

Since useDatabase() is based on db0 (that quite early in development), would this mean that this feature will be postponed till a later Nitro 3.x version?

@pi0
Copy link

pi0 commented Apr 11, 2024

useDatabase() will be eventually enabled out of the box for Nitro v2 as well.

In the meantime I appreciate any feedback from direct db0 integration which can help to stabilize and discover any issues with it.

@atinux atinux mentioned this pull request Aug 19, 2024
Open
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Sep 16, 2024 •
edited
Loading

Deploying playground with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7e1c884
Status: ✅  Deploy successful!
Preview URL: https://526bcf52.playground-bhb.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpreston321 cpreston321 cpreston321 left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure Nitro database to use hubDatabase()
4 participants
@atinux @cpreston321 @sandros94 @pi0