2711-Testcase-fix (Sourcery refactored) #4299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
|
Sourcery AI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## wip-NXDRIVE-Testcase-fix-2711 #4299 +/- ##
=================================================================
- Coverage 47.79% 47.77% -0.02%
=================================================================
Files 94 94
Lines 15678 15673 -5
=================================================================
- Hits 7493 7488 -5
Misses 8185 8185
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sourcery-ai
bot
force-pushed
the
sourcery/wip-NXDRIVE-Testcase-fix-2711
branch
from
0e5376e to
f1185b4
Compare
sourcery-ai
bot
force-pushed
the
sourcery/wip-NXDRIVE-Testcase-fix-2711
branch
from
f1185b4 to
0c8e0fa
Compare
Comment on lines
-127
to
+134
| for engine in self.manager.engines.copy().values(): | ||
| if engine.remote: | ||
| return engine.remote.client.server_version # type: ignore | ||
| return None | ||
| return next( | ||
| ( | ||
| engine.remote.client.server_version | ||
| for engine in self.manager.engines.copy().values() | ||
| if engine.remote | ||
| ), | ||
| None, | ||
| ) |
Comment on lines
-160
to
+167
| if exc.errno in NO_SPACE_ERRORS: | ||
| log.warning("Update failed, disk space needed", exc_info=True) | ||
| self.noSpaceLeftOnDevice.emit() | ||
| else: | ||
| if exc.errno not in NO_SPACE_ERRORS: | ||
| raise | ||
| log.warning("Update failed, disk space needed", exc_info=True) | ||
| self.noSpaceLeftOnDevice.emit() |
There was a problem hiding this comment.
Function BaseUpdater.update refactored with the following changes:
- Swap if/else branches (
swap-if-else-branches) - Remove unnecessary else after guard condition (
remove-unnecessary-else)
Comment on lines
-182
to
+185
| path = os.path.join(gettempdir(), uuid.uuid4().hex + "_" + name) | ||
| path = os.path.join(gettempdir(), f"{uuid.uuid4().hex}_{name}") |
There was a problem hiding this comment.
Function BaseUpdater._download refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
Comment on lines
-302
to
+311
| versions = { | ||
| if versions := { | ||
| version: info | ||
| for version, info in self.versions.items() | ||
| if info.get("type", "").lower() | ||
| in (self.manager.get_update_channel(), "release") | ||
| and version_lt(version, "4") | ||
| } | ||
| if versions: | ||
| }: |
There was a problem hiding this comment.
Function BaseUpdater.force_downgrade refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Comment on lines
-366
to
+368
| info = self.versions.get(version) | ||
| if info: | ||
| if info := self.versions.get(version): |
There was a problem hiding this comment.
Function BaseUpdater.get_version_channel refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request #4298 refactored by Sourcery.
If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
wip-NXDRIVE-Testcase-fix-2711branch, then run:Help us improve this pull request!