samples/client: get BAR1 size from region info#873
Merged
tmakatos merged 1 commit intoJul 7, 2026
Conversation
Retrieve the BAR1 size from VFIO_USER_DEVICE_GET_REGION_INFO instead of relying on a hardcoded value. This removes the existing FIXME and allows the client to use the size reported by the server. Signed-off-by: Siddharth C <siddharthcibi@icloud.com>
Contributor
Author
|
While testing this change with ASan enabled, I noticed a memory leak reported in the sample client. It appears to originate somewhere in the migration path (do_migrate()/migrate_from()) and I don't believe this change introduces it, but I'm not certain of the exact source.Is this a known issue? Happy to investigate and address it in |
Collaborator
Not a known issue, feel free to fix. |
tmakatos
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace the hardcoded BAR1 size in the sample client with the size reported by VFIO_USER_DEVICE_GET_REGION_INFO.
This removes the existing FIXME and ensures the client uses the BAR1 size provided by the server instead of relying on a hardcoded value.
Testing