Conversation
Also, refactoring some code
Editing some things to match coding standard and adding customizations
kind of a messy implementation :'(
and some debugging / refactoring / changes in text
with regression testing; small change to output message
And some more debugging / refactoring
quitejasper
reviewed
Feb 4, 2022
quitejasper
left a comment
quitejasper
left a comment
There was a problem hiding this comment.
Overall really impressed with your work. I believe you have put in a lot of effort in this. Well done!
cheshire-doge
left a comment
cheshire-doge
left a comment
There was a problem hiding this comment.
I think you did a great job following coding conventions! I could not spot any glaring issues, keep up the good work!
branch-Level-5
Divide classes into packages duke and duke.task
Branch level 6
Branch level 7
xseh
reviewed
Feb 16, 2022
xseh
left a comment
xseh
left a comment
There was a problem hiding this comment.
Good job! Consider removing the magic literals and refactor for better code readability.
| } | ||
| curr = list.get(taskNum); | ||
| } catch (IndexOutOfBoundsException | NumberFormatException e) { | ||
| // NumberFormatException caught in IntelliJ runtime env but not in testing... |
There was a problem hiding this comment.
Consider writing to the reader instead of private notes to yourself.
Comment on lines
+107
to
+109
| String[] deadlineBreakdown = description.split("/by ", 2); | ||
| description = deadlineBreakdown[0]; | ||
| by = deadlineBreakdown[1]; |
There was a problem hiding this comment.
Consider refactoring code into a separate method since it is needed later.
Add find feature and relevant test cases
Merge new changes in master to branch-A-JavaDoc
Branch a java doc
I absolutely don't know how to fix this formatting anymore, and not having Jekyll set-up locally means pushing every time to see the rendering. This is getting embarrassing, I give up :((
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.