Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

152 feature add onerror hook support #156

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

nurrony
Copy link
Owner

@nurrony nurrony commented Mar 22, 2024

What does this MR do?

Add hook support for download process like below

const downloader = new HLSDownloader({
  onError: (error) => {
     console.error('error details', error);
  }
})

Error Object Details

{
  url: "<URLofTheItem>",
  name: "<ErrorName>",
  message: "<HumanReableMessage>",
}

Are there points in the code the reviewer needs to double check?

// Please add some brief description here

Why was this MR needed?

Check #147

Dependent MR Link

closes #152
closes #154
closes #155

Screenshots (if relevant)

// Please add some description here

Does this MR meet the acceptance criteria?

@nurrony nurrony linked an issue Mar 22, 2024 that may be closed by this pull request
5 tasks
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 78.80%. Comparing base (2eef599) to head (7dea47c).

Files Patch % Lines
src/Downloader.js 33.33% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   83.21%   78.80%   -4.41%     
==========================================
  Files           4        4              
  Lines         137      151      +14     
  Branches       15       21       +6     
==========================================
+ Hits          114      119       +5     
- Misses         12       17       +5     
- Partials       11       15       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nurrony nurrony merged commit 9f6bc2e into master Mar 22, 2024
2 of 4 checks passed
Copy link

🎉 This PR is included in version 3.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nurrony nurrony mentioned this pull request Mar 22, 2024
3 tasks
@nurrony nurrony deleted the feature/152-feature-add-onerror-hook-support branch March 23, 2024 05:27
@nurrony nurrony self-assigned this Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change data signature for onData Add documentation for onError function Feature: Add onError hook support
1 participant