-
Notifications
You must be signed in to change notification settings - Fork 10
flatten var at top of functions. #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
00a9554
Test name with srcPath
rachitnigam 7b6e86b
Get basename for test name.
rachitnigam a1b8a74
Also for browser tests.
rachitnigam 00d8286
flatten var at top of functions.
rachitnigam 397f52e
Fix lifted call.
rachitnigam 1edb87e
Ignore vscode. I use a real editor now.
rachitnigam 4f783ae
Merge branch 'master' into flatdecl
rachitnigam ddff949
Merge branch 'master' into flatdecl
rachitnigam 4ed08af
Merge branch 'master' into flatdecl
rachitnigam f39887b
Merge branch 'master' into flatdecl
rachitnigam 4145074
Merge branch 'master' into flatdecl
rachitnigam 84af5d4
Merge branch 'master' into flatdecl
arjunguha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,3 +11,4 @@ demo-webpage/html/runner.js | |
| package-lock.json | ||
| auth-trial/html/src-noconflict | ||
| /benchmarks | ||
| .vscode | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, why? you need to stick to vim for a little longer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah well, I wanted to feel like I wasn't in the 90s (plus I finally got a computer that can support an actual editor) . Didn't really work out. VS Code's vim emulation isn't that great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, being fluent in Vim or Emacs is an important part of street cred. But you probably have that already.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I am fluent in vim. I even wrote most of the vim stuff for pyret: brownplt/pyret-lang#1150
(the name of the PR is in sync with the Pyret theme :) )