Skip to content

Comments

Link built-in attribute implementations in extensibility interface docs#1138

Merged
SeanKilleen merged 2 commits intomasterfrom
copilot/update-custom-attributes-links
Feb 20, 2026
Merged

Link built-in attribute implementations in extensibility interface docs#1138
SeanKilleen merged 2 commits intomasterfrom
copilot/update-custom-attributes-links

Conversation

Copy link
Contributor

Copilot AI commented Feb 20, 2026

The interface documentation pages under Custom Attributes listed NUnit's built-in implementations as plain text, missing an opportunity to direct readers to the attribute documentation they'd likely want as implementation examples.

Changes

  • Replaced plain-text attribute names with markdown links to their respective docs pages across all 8 interface pages:
    • IApplyToContext-Interface.md — 6 attributes linked
    • IApplyToTest-Interface.md — 10 attributes linked (CombiningStrategyAttribute has no dedicated page; left as plain text)
    • ICommandWrapper-Interface.md — 3 attributes linked
    • IFixtureBuilder-Interface.md — 3 attributes linked
    • ITestBuilder-Interface.md — 6 attributes linked (derived classes of CombiningStrategyAttribute linked individually; parent left as plain text)
    • ISimpleTestBuilder-Interface.md — 1 attribute linked
    • IParameterDataSource-Interface.md — 4 attributes linked
    • IImplyFixture-Interface.md — 4 attributes linked

All links use relative paths (e.g. ../writing-tests/attributes/timeout.md) consistent with the existing doc structure.

Original prompt

This section details on the original issue you should resolve

<issue_title>Update Custom Attributes interfaces pages to link to implementations</issue_title>
<issue_description>Each of the interfaces defined as an extensibility endpoint has a documentation page listed under https://docs.nunit.org/articles/nunit/extending-nunit/Custom-Attributes.html

Each of those pages in turn contains a list of built-in implementations within NUnit. Each of these are listed as a static list with the name of the attribute as text. Someone reviewing the page may be looking for examples of how to implement the interface. It may help them in their quest if we update the documentation to link to documentation about the attribute itself. </issue_description>

<agent_instructions>Each of the interfaces defined as an extensibility endpoint has a documentation page listed under https://docs.nunit.org/articles/nunit/extending-nunit/Custom-Attributes.html

Each of those pages in turn contains a list of built-in implementations within NUnit near the bottom. Each list is static text with the name of an NUnit attribute Please update those to link to documentation about the attribute itself.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…ntations

Co-authored-by: stevenaw <439844+stevenaw@users.noreply.github.com>
Copilot AI changed the title [WIP] Update custom attributes interfaces pages to link to implementations Link built-in attribute implementations in extensibility interface docs Feb 20, 2026
Copilot AI requested a review from stevenaw February 20, 2026 17:47
@stevenaw stevenaw marked this pull request as ready for review February 20, 2026 17:58
Copy link
Member

@stevenaw stevenaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Copilot

Copy link
Member

@OsirisTerje OsirisTerje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@SeanKilleen
Copy link
Member

Sweet! Great use of Copilot @stevenaw!

@SeanKilleen SeanKilleen merged commit e543c9d into master Feb 20, 2026
7 checks passed
@SeanKilleen SeanKilleen deleted the copilot/update-custom-attributes-links branch February 20, 2026 18:21
github-actions bot pushed a commit that referenced this pull request Feb 20, 2026
…cs (#1138)

* Initial plan

* Update Custom Attributes interface pages to link to attribute implementations

Co-authored-by: stevenaw <439844+stevenaw@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: stevenaw <439844+stevenaw@users.noreply.github.com> e543c9d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Custom Attributes interfaces pages to link to implementations

4 participants