-
Notifications
You must be signed in to change notification settings - Fork 2
Add minimum kubebuilder and direnv setup #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b002c37
Add kubebuilder and direnv setup
rytswd 106d2d5
Add API spec and its dedicated module path
rytswd f0d260b
Add kubebuilder PROJECT
rytswd e29cfa3
Add Makefile based on kubebuilder template
rytswd 7dbc258
Update devshell.nix
rytswd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| #!/usr/bin/env bash | ||
| # Used by https://direnv.net | ||
|
|
||
| # Automatically reload when this file changes | ||
| watch_file devshell.nix | ||
|
|
||
| # Load `nix develop` | ||
| use flake | ||
|
|
||
| # Extend the environment with per-user overrides | ||
| source_env_if_exists .envrc.local | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,238 @@ | ||
| # Image URL to use all building/pushing image targets | ||
| IMG ?= controller:latest | ||
|
|
||
| # Get the currently used golang install path (in GOPATH/bin, unless GOBIN is set) | ||
| ifeq (,$(shell go env GOBIN)) | ||
| GOBIN=$(shell go env GOPATH)/bin | ||
| else | ||
| GOBIN=$(shell go env GOBIN) | ||
| endif | ||
|
|
||
| # CONTAINER_TOOL defines the container tool to be used for building images. | ||
| # Be aware that the target commands are only tested with Docker which is | ||
| # scaffolded by default. However, you might want to replace it to use other | ||
| # tools. (i.e. podman) | ||
| CONTAINER_TOOL ?= docker | ||
|
|
||
| # Setting SHELL to bash allows bash commands to be executed by recipes. | ||
| # Options are set to exit when a recipe line exits non-zero or a piped command fails. | ||
| SHELL = /usr/bin/env bash -o pipefail | ||
| .SHELLFLAGS = -ec | ||
|
|
||
| .PHONY: all | ||
| all: build | ||
|
|
||
| ##@ General | ||
|
|
||
| # The help target prints out all targets with their descriptions organized | ||
| # beneath their categories. The categories are represented by '##@' and the | ||
| # target descriptions by '##'. The awk command is responsible for reading the | ||
| # entire set of makefiles included in this invocation, looking for lines of the | ||
| # file as xyz: ## something, and then pretty-format the target and help. Then, | ||
| # if there's a line with ##@ something, that gets pretty-printed as a category. | ||
| # More info on the usage of ANSI control characters for terminal formatting: | ||
| # https://en.wikipedia.org/wiki/ANSI_escape_code#SGR_parameters | ||
| # More info on the awk command: | ||
| # http://linuxcommand.org/lc3_adv_awk.php | ||
|
|
||
| .PHONY: help | ||
| help: ## Display this help. | ||
| @awk 'BEGIN {FS = ":.*##"; printf "\nUsage:\n make \033[36m<target>\033[0m\n"} /^[a-zA-Z_0-9-]+:.*?##/ { printf " \033[36m%-15s\033[0m %s\n", $$1, $$2 } /^##@/ { printf "\n\033[1m%s\033[0m\n", substr($$0, 5) } ' $(MAKEFILE_LIST) | ||
|
|
||
| ##@ Development | ||
|
|
||
| .PHONY: manifests | ||
| manifests: controller-gen ## Generate WebhookConfiguration, ClusterRole and CustomResourceDefinition objects. | ||
| $(CONTROLLER_GEN) rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases | ||
|
|
||
| .PHONY: generate | ||
| generate: controller-gen ## Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations. | ||
| $(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./..." | ||
|
|
||
| .PHONY: fmt | ||
| fmt: ## Run go fmt against code. | ||
| go fmt ./... | ||
|
|
||
| .PHONY: vet | ||
| vet: ## Run go vet against code. | ||
| go vet ./... | ||
|
|
||
| .PHONY: test | ||
| test: manifests generate fmt vet setup-envtest ## Run tests. | ||
| KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" go test $$(go list ./... | grep -v /e2e) -coverprofile cover.out | ||
|
|
||
| # TODO(user): To use a different vendor for e2e tests, modify the setup under 'tests/e2e'. | ||
| # The default setup assumes Kind is pre-installed and builds/loads the Manager Docker image locally. | ||
| # CertManager is installed by default; skip with: | ||
| # - CERT_MANAGER_INSTALL_SKIP=true | ||
| KIND_CLUSTER ?= multigres-operator-test-e2e | ||
|
|
||
| .PHONY: setup-test-e2e | ||
| setup-test-e2e: ## Set up a Kind cluster for e2e tests if it does not exist | ||
| @command -v $(KIND) >/dev/null 2>&1 || { \ | ||
| echo "Kind is not installed. Please install Kind manually."; \ | ||
| exit 1; \ | ||
| } | ||
| @case "$$($(KIND) get clusters)" in \ | ||
| *"$(KIND_CLUSTER)"*) \ | ||
| echo "Kind cluster '$(KIND_CLUSTER)' already exists. Skipping creation." ;; \ | ||
| *) \ | ||
| echo "Creating Kind cluster '$(KIND_CLUSTER)'..."; \ | ||
| $(KIND) create cluster --name $(KIND_CLUSTER) ;; \ | ||
| esac | ||
|
|
||
| .PHONY: test-e2e | ||
| test-e2e: setup-test-e2e manifests generate fmt vet ## Run the e2e tests. Expected an isolated environment using Kind. | ||
| KIND=$(KIND) KIND_CLUSTER=$(KIND_CLUSTER) go test -tags=e2e ./test/e2e/ -v -ginkgo.v | ||
| $(MAKE) cleanup-test-e2e | ||
|
|
||
| .PHONY: cleanup-test-e2e | ||
| cleanup-test-e2e: ## Tear down the Kind cluster used for e2e tests | ||
| @$(KIND) delete cluster --name $(KIND_CLUSTER) | ||
|
|
||
| .PHONY: lint | ||
| lint: golangci-lint ## Run golangci-lint linter | ||
| $(GOLANGCI_LINT) run | ||
|
|
||
| .PHONY: lint-fix | ||
| lint-fix: golangci-lint ## Run golangci-lint linter and perform fixes | ||
| $(GOLANGCI_LINT) run --fix | ||
|
|
||
| .PHONY: lint-config | ||
| lint-config: golangci-lint ## Verify golangci-lint linter configuration | ||
| $(GOLANGCI_LINT) config verify | ||
|
|
||
| ##@ Build | ||
|
|
||
| .PHONY: build | ||
| build: manifests generate fmt vet ## Build manager binary. | ||
| go build -o bin/manager cmd/main.go | ||
|
|
||
| .PHONY: run | ||
| run: manifests generate fmt vet ## Run a controller from your host. | ||
| go run ./cmd/main.go | ||
|
|
||
| # If you wish to build the manager image targeting other platforms you can use the --platform flag. | ||
| # (i.e. docker build --platform linux/arm64). However, you must enable docker buildKit for it. | ||
| # More info: https://docs.docker.com/develop/develop-images/build_enhancements/ | ||
| .PHONY: docker-build | ||
| docker-build: ## Build docker image with the manager. | ||
| $(CONTAINER_TOOL) build -t ${IMG} . | ||
|
|
||
| .PHONY: docker-push | ||
| docker-push: ## Push docker image with the manager. | ||
| $(CONTAINER_TOOL) push ${IMG} | ||
|
|
||
| # PLATFORMS defines the target platforms for the manager image be built to provide support to multiple | ||
| # architectures. (i.e. make docker-buildx IMG=myregistry/mypoperator:0.0.1). To use this option you need to: | ||
| # - be able to use docker buildx. More info: https://docs.docker.com/build/buildx/ | ||
| # - have enabled BuildKit. More info: https://docs.docker.com/develop/develop-images/build_enhancements/ | ||
| # - be able to push the image to your registry (i.e. if you do not set a valid value via IMG=<myregistry/image:<tag>> then the export will fail) | ||
| # To adequately provide solutions that are compatible with multiple platforms, you should consider using this option. | ||
| PLATFORMS ?= linux/arm64,linux/amd64,linux/s390x,linux/ppc64le | ||
| .PHONY: docker-buildx | ||
| docker-buildx: ## Build and push docker image for the manager for cross-platform support | ||
| # copy existing Dockerfile and insert --platform=${BUILDPLATFORM} into Dockerfile.cross, and preserve the original Dockerfile | ||
| sed -e '1 s/\(^FROM\)/FROM --platform=\$$\{BUILDPLATFORM\}/; t' -e ' 1,// s//FROM --platform=\$$\{BUILDPLATFORM\}/' Dockerfile > Dockerfile.cross | ||
| - $(CONTAINER_TOOL) buildx create --name multigres-operator-builder | ||
| $(CONTAINER_TOOL) buildx use multigres-operator-builder | ||
| - $(CONTAINER_TOOL) buildx build --push --platform=$(PLATFORMS) --tag ${IMG} -f Dockerfile.cross . | ||
| - $(CONTAINER_TOOL) buildx rm multigres-operator-builder | ||
| rm Dockerfile.cross | ||
|
|
||
| .PHONY: build-installer | ||
| build-installer: manifests generate kustomize ## Generate a consolidated YAML with CRDs and deployment. | ||
| mkdir -p dist | ||
| cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG} | ||
| $(KUSTOMIZE) build config/default > dist/install.yaml | ||
|
|
||
| ##@ Deployment | ||
|
|
||
| ifndef ignore-not-found | ||
| ignore-not-found = false | ||
| endif | ||
|
|
||
| .PHONY: install | ||
| install: manifests kustomize ## Install CRDs into the K8s cluster specified in ~/.kube/config. | ||
| $(KUSTOMIZE) build config/crd | $(KUBECTL) apply -f - | ||
|
|
||
| .PHONY: uninstall | ||
| uninstall: manifests kustomize ## Uninstall CRDs from the K8s cluster specified in ~/.kube/config. Call with ignore-not-found=true to ignore resource not found errors during deletion. | ||
| $(KUSTOMIZE) build config/crd | $(KUBECTL) delete --ignore-not-found=$(ignore-not-found) -f - | ||
|
|
||
| .PHONY: deploy | ||
| deploy: manifests kustomize ## Deploy controller to the K8s cluster specified in ~/.kube/config. | ||
| cd config/manager && $(KUSTOMIZE) edit set image controller=${IMG} | ||
| $(KUSTOMIZE) build config/default | $(KUBECTL) apply -f - | ||
|
|
||
| .PHONY: undeploy | ||
| undeploy: kustomize ## Undeploy controller from the K8s cluster specified in ~/.kube/config. Call with ignore-not-found=true to ignore resource not found errors during deletion. | ||
| $(KUSTOMIZE) build config/default | $(KUBECTL) delete --ignore-not-found=$(ignore-not-found) -f - | ||
|
|
||
| ##@ Dependencies | ||
|
|
||
| ## Location to install dependencies to | ||
| LOCALBIN ?= $(shell pwd)/bin | ||
rcambrj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| $(LOCALBIN): | ||
| mkdir -p $(LOCALBIN) | ||
|
|
||
| ## Tool Binaries | ||
| KUBECTL ?= kubectl | ||
| KIND ?= kind | ||
| KUSTOMIZE ?= $(LOCALBIN)/kustomize | ||
| CONTROLLER_GEN ?= $(LOCALBIN)/controller-gen | ||
| ENVTEST ?= $(LOCALBIN)/setup-envtest | ||
| GOLANGCI_LINT = $(LOCALBIN)/golangci-lint | ||
|
|
||
| ## Tool Versions | ||
| KUSTOMIZE_VERSION ?= v5.6.0 | ||
| CONTROLLER_TOOLS_VERSION ?= v0.18.0 | ||
| #ENVTEST_VERSION is the version of controller-runtime release branch to fetch the envtest setup script (i.e. release-0.20) | ||
| ENVTEST_VERSION ?= $(shell go list -m -f "{{ .Version }}" sigs.k8s.io/controller-runtime | awk -F'[v.]' '{printf "release-%d.%d", $$2, $$3}') | ||
| #ENVTEST_K8S_VERSION is the version of Kubernetes to use for setting up ENVTEST binaries (i.e. 1.31) | ||
| ENVTEST_K8S_VERSION ?= $(shell go list -m -f "{{ .Version }}" k8s.io/api | awk -F'[v.]' '{printf "1.%d", $$3}') | ||
| GOLANGCI_LINT_VERSION ?= v2.3.0 | ||
|
|
||
| .PHONY: kustomize | ||
| kustomize: $(KUSTOMIZE) ## Download kustomize locally if necessary. | ||
| $(KUSTOMIZE): $(LOCALBIN) | ||
| $(call go-install-tool,$(KUSTOMIZE),sigs.k8s.io/kustomize/kustomize/v5,$(KUSTOMIZE_VERSION)) | ||
|
|
||
| .PHONY: controller-gen | ||
| controller-gen: $(CONTROLLER_GEN) ## Download controller-gen locally if necessary. | ||
| $(CONTROLLER_GEN): $(LOCALBIN) | ||
| $(call go-install-tool,$(CONTROLLER_GEN),sigs.k8s.io/controller-tools/cmd/controller-gen,$(CONTROLLER_TOOLS_VERSION)) | ||
|
|
||
| .PHONY: setup-envtest | ||
| setup-envtest: envtest ## Download the binaries required for ENVTEST in the local bin directory. | ||
| @echo "Setting up envtest binaries for Kubernetes version $(ENVTEST_K8S_VERSION)..." | ||
| @$(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path || { \ | ||
| echo "Error: Failed to set up envtest binaries for version $(ENVTEST_K8S_VERSION)."; \ | ||
| exit 1; \ | ||
| } | ||
|
|
||
| .PHONY: envtest | ||
| envtest: $(ENVTEST) ## Download setup-envtest locally if necessary. | ||
| $(ENVTEST): $(LOCALBIN) | ||
| $(call go-install-tool,$(ENVTEST),sigs.k8s.io/controller-runtime/tools/setup-envtest,$(ENVTEST_VERSION)) | ||
|
|
||
| .PHONY: golangci-lint | ||
| golangci-lint: $(GOLANGCI_LINT) ## Download golangci-lint locally if necessary. | ||
| $(GOLANGCI_LINT): $(LOCALBIN) | ||
| $(call go-install-tool,$(GOLANGCI_LINT),github.com/golangci/golangci-lint/v2/cmd/golangci-lint,$(GOLANGCI_LINT_VERSION)) | ||
|
|
||
| # go-install-tool will 'go install' any package with custom target and name of binary, if it doesn't exist | ||
| # $1 - target path with name of binary | ||
| # $2 - package url which can be installed | ||
| # $3 - specific version of package | ||
| define go-install-tool | ||
| @[ -f "$(1)-$(3)" ] && [ "$$(readlink -- "$(1)" 2>/dev/null)" = "$(1)-$(3)" ] || { \ | ||
| set -e; \ | ||
| package=$(2)@$(3) ;\ | ||
| echo "Downloading $${package}" ;\ | ||
| rm -f $(1) ;\ | ||
| GOBIN=$(LOCALBIN) go install $${package} ;\ | ||
| mv $(1) $(1)-$(3) ;\ | ||
| } ;\ | ||
| ln -sf $$(realpath $(1)-$(3)) $(1) | ||
| endef | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| # Code generated by tool. DO NOT EDIT. | ||
| # This file is used to track the info used to scaffold your project | ||
| # and allow the plugins properly work. | ||
| # More info: https://book.kubebuilder.io/reference/project-config.html | ||
| cliVersion: v4.8.0 | ||
| domain: multigres.com | ||
| layout: | ||
| - go.kubebuilder.io/v4 | ||
| projectName: multigres-operator | ||
| repo: github.com/numtide/multigres-operator | ||
| resources: | ||
| - api: | ||
| crdVersion: v1 | ||
| namespaced: true | ||
| controller: true | ||
| domain: multigres.com | ||
| group: multigres | ||
| kind: MultiGateway | ||
| path: github.com/numtide/multigres-operator/api/v1alpha1 | ||
| version: v1alpha1 | ||
| - api: | ||
| crdVersion: v1 | ||
| namespaced: true | ||
| domain: multigres.com | ||
| group: multigres | ||
| kind: MultiPooler | ||
| path: github.com/numtide/multigres-operator/api/v1alpha1 | ||
| version: v1alpha1 | ||
| - api: | ||
| crdVersion: v1 | ||
| namespaced: true | ||
| domain: multigres.com | ||
| group: multigres | ||
| kind: Etcd | ||
| path: github.com/numtide/multigres-operator/api/v1alpha1 | ||
| version: v1alpha1 | ||
| - api: | ||
| crdVersion: v1 | ||
| namespaced: true | ||
| domain: multigres.com | ||
| group: multigres | ||
| kind: MultiOrch | ||
| path: github.com/numtide/multigres-operator/api/v1alpha1 | ||
| version: v1alpha1 | ||
| version: "3" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| module github.com/numtide/multigres-operator/api | ||
|
|
||
| go 1.25.0 | ||
|
|
||
| require ( | ||
| k8s.io/apimachinery v0.34.1 | ||
| sigs.k8s.io/controller-runtime v0.22.2 | ||
| ) | ||
|
|
||
| require ( | ||
| github.com/fxamacker/cbor/v2 v2.9.0 // indirect | ||
| github.com/go-logr/logr v1.4.2 // indirect | ||
| github.com/gogo/protobuf v1.3.2 // indirect | ||
| github.com/json-iterator/go v1.1.12 // indirect | ||
| github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect | ||
| github.com/modern-go/reflect2 v1.0.3-0.20250322232337-35a7c28c31ee // indirect | ||
| github.com/x448/float16 v0.8.4 // indirect | ||
| go.yaml.in/yaml/v2 v2.4.2 // indirect | ||
| golang.org/x/net v0.38.0 // indirect | ||
| golang.org/x/text v0.23.0 // indirect | ||
| gopkg.in/inf.v0 v0.9.1 // indirect | ||
| k8s.io/klog/v2 v2.130.1 // indirect | ||
| k8s.io/utils v0.0.0-20250604170112-4c0f3b243397 // indirect | ||
| sigs.k8s.io/json v0.0.0-20241014173422-cfa47c3a1cc8 // indirect | ||
| sigs.k8s.io/randfill v1.0.0 // indirect | ||
| sigs.k8s.io/structured-merge-diff/v6 v6.3.0 // indirect | ||
| ) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.