Skip to content

Conversation

guan404ming
Copy link
Member

Copy link
Collaborator

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My 2 cents: the proposed addition of "Tutorials of" is redundant, as this is already explicitly a tutorials site. I'm -0.5 on changing the titles but will readily acquiesce if other reviewers prefer it!

@melissawm
Copy link
Member

I agree with @rossbar, I think this is a bit redundant.

@guan404ming
Copy link
Member Author

guan404ming commented Jul 23, 2024

Thanks for the reviews! I added "Tutorials of" because directly going to the feature page and application page doesn't clearly indicate it's a tutorial which may cause some confusion. But I'm happy with whatever reviewers prefer!. Thanks again!

@bsipocz
Copy link
Member

bsipocz commented Jul 23, 2024

I also agree with the other maintainers.

However, maybe we can have a different logo flavour, after all it doesn't link back to https://numpy.org but to https://numpy.org/numpy-tutorials/

@guan404ming
Copy link
Member Author

I totally agree that having a different logo will prevent confusion. Thanks a lot for your time, everyone. I'll close this PR now~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants