Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1712: Adds support for JS in Anon Api #3163

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

nickzelei
Copy link
Member

  • Adds support for javascript in anonymization api
  • Refactors JS VM out of Benthos processor for easier re-use

@nickzelei nickzelei added enhancement New feature or request Tech Debt Created by Linear-GitHub Sync labels Jan 17, 2025
Copy link

linear bot commented Jan 17, 2025

Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2025 1:04am

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 704 lines in your changes missing coverage. Please review.

Project coverage is 7.43%. Comparing base (0f57e26) to head (663e4c3).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...orker/pkg/benthos/transformer_executor/executor.go 0.00% 138 Missing ⚠️
internal/javascript/functions/benthos/functions.go 0.00% 111 Missing ⚠️
internal/javascript/functions/neosync/functions.go 0.00% 96 Missing ⚠️
internal/javascript/functions/functions.go 0.00% 80 Missing ⚠️
internal/javascript/vm/vm.go 0.00% 77 Missing ⚠️
internal/benthos_slogger/logger.go 0.00% 57 Missing ⚠️
worker/pkg/benthos/javascript/processor.go 0.00% 49 Missing ⚠️
internal/javascript/javascript.go 0.00% 28 Missing ⚠️
worker/pkg/benthos/javascript/benthos_value_api.go 0.00% 18 Missing ⚠️
...pkg/benthos/transformer_executor/anon_value_api.go 0.00% 18 Missing ⚠️
... and 5 more

❗ There is a different number of reports uploaded between BASE (0f57e26) and HEAD (663e4c3). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (0f57e26) HEAD (663e4c3)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #3163       +/-   ##
==========================================
- Coverage   29.85%   7.43%   -22.43%     
==========================================
  Files         372     377        +5     
  Lines       42963   43012       +49     
==========================================
- Hits        12828    3196     -9632     
- Misses      28614   39237    +10623     
+ Partials     1521     579      -942     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Tech Debt Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant