Skip to content

Commit

Permalink
Removed TOOLS_VERSION, rewritten commands to use only docker-compose …
Browse files Browse the repository at this point in the history
…with TOOLS_VERSION inside .env.
  • Loading branch information
MartinMikita committed Dec 16, 2019
1 parent 32433a5 commit 434c050
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 14 deletions.
7 changes: 2 additions & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ DC_OPTS?=--rm
# container runs as the current user rather than root (so that created files are not root-owned)
DC_USER_OPTS?=$(DC_OPTS) -u $$(id -u $${USER}):$$(id -g $${USER})

TOOLS_VERSION?=$(shell cat TOOLS_VERSION)
export TOOLS_VERSION

.PHONY: all
all: build/openmaptiles.tm2source/data.yml build/mapping.yaml build/tileset.sql

Expand Down Expand Up @@ -182,7 +179,7 @@ etl-graph:

# generate etl graph for a certain layer, e.g. etl-graph-building, etl-graph-place
etl-graph-%: layers/% build/devdoc
docker run $(DC_USER_OPTS) -v $$(pwd):/tileset openmaptiles/openmaptiles-tools:${TOOLS_VERSION} generate-etlgraph layers/$*/$*.yaml ./build/devdoc
docker-compose run $(DC_USER_OPTS) openmaptiles-tools generate-etlgraph layers/$*/$*.yaml ./build/devdoc
cp ./build/devdoc/etl_$*.png layers/$*/etl_diagram.png


Expand All @@ -197,7 +194,7 @@ mapping-graph:
@echo 'Valid layers: $(mappingLayers)'

mapping-graph-%: ./layers/%/mapping.yaml build/devdoc
docker run $(DC_USER_OPTS) -v $$(pwd):/tileset openmaptiles/openmaptiles-tools:${TOOLS_VERSION} generate-mapping-graph layers/$*/$*.yaml ./build/devdoc/mapping-diagram-$*
docker-compose run $(DC_USER_OPTS) openmaptiles-tools generate-mapping-graph layers/$*/$*.yaml ./build/devdoc/mapping-diagram-$*
cp ./build/devdoc/mapping-diagram-$*.png layers/$*/mapping_diagram.png

# generate all etl and mapping graphs
Expand Down
1 change: 0 additions & 1 deletion TOOLS_VERSION

This file was deleted.

3 changes: 1 addition & 2 deletions qa/layer_freq.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ do
echo " "
echo "## $layerid z$z - freq"

: "${TOOLS_VERSION:=$(cat "$(dirname "$0")/../TOOLS_VERSION")}"
SQL=$(docker run --rm -v "$(pwd):/tileset" "openmaptiles/openmaptiles-tools:$TOOLS_VERSION" generate-sqlquery layers/${layerid}/${layerid}.yaml $z )
SQL=$(docker-compose run --rm openmaptiles-tools generate-sqlquery layers/${layerid}/${layerid}.yaml $z )

SQLCODE=$(cat <<-END
select $classvars , count(*) as _count_ from
Expand Down
3 changes: 1 addition & 2 deletions qa/layer_numvar_analyze.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ do
echo " "
echo "## $layerid z$z - $var "

: "${TOOLS_VERSION:=$(cat "$(dirname "$0")/../TOOLS_VERSION")}"
SQL=$(docker run --rm -v "$(pwd):/tileset" "openmaptiles/openmaptiles-tools:$TOOLS_VERSION" generate-sqlquery layers/${layerid}/${layerid}.yaml $z )
SQL=$(docker-compose run --rm openmaptiles-tools generate-sqlquery layers/${layerid}/${layerid}.yaml $z )

SQLCODE=$(cat <<-END
SELECT
Expand Down
3 changes: 1 addition & 2 deletions qa/layer_toplength.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ do
echo " "
echo "## $layerid z$z max length ($classvar)"

: "${TOOLS_VERSION:=$(cat "$(dirname "$0")/../TOOLS_VERSION")}"
SQL=$(docker run --rm -v "$(pwd):/tileset" "openmaptiles/openmaptiles-tools:$TOOLS_VERSION" generate-sqlquery layers/${layerid}/${layerid}.yaml $z )
SQL=$(docker-compose run --rm openmaptiles-tools generate-sqlquery layers/${layerid}/${layerid}.yaml $z )

SQLCODE=$(cat <<-END
SELECT DISTINCT $classvar , length( $classvar ) AS _length_ from
Expand Down
2 changes: 0 additions & 2 deletions quickstart.sh
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ MIN_DOCKER_VER=1.12.3
STARTTIME=$(date +%s)
STARTDATE=$(date +"%Y-%m-%dT%H:%M%z")
githash=$( git rev-parse HEAD )
: "${TOOLS_VERSION:=$(cat "$(dirname "$0")/TOOLS_VERSION")}"
export TOOLS_VERSION

# Options to run with docker and docker-compose - ensure the container is destroyed on exit,
# as well as pass any other common parameters.
Expand Down

0 comments on commit 434c050

Please sign in to comment.