reader: by default, archive failed messages to disk#135
Open
jehiah wants to merge 1 commit intonsqio:masterfrom
Open
reader: by default, archive failed messages to disk#135jehiah wants to merge 1 commit intonsqio:masterfrom
jehiah wants to merge 1 commit intonsqio:masterfrom
Conversation
Member
Author
|
RFR @mreiferson. I'd love any naming comments you have, and if you can think of an obvious way to disable this (an additional parameter of |
Member
There was a problem hiding this comment.
I don't see where this is being initialized?
Member
Author
There was a problem hiding this comment.
haha. just copy & pasting from my custom giving_up() here. I'll try some real validation =)
Member
|
@jehiah should we also bump |
Member
|
Do we need to provide a param to disable archiving when we already encourage users to subclass and override the method? |
Member
|
what're we doing on this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #134 and changes the default behaviour of
Reader.give_up()to be less surprising by writing messages that are "given up on" to disk instead of dropping them completely.