Update userProfileData and logoutRequest #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When fetching a user’s profile with GetUserProfileRequest, the resulting data object is different from the UserData object we get from Log in. Our proto was missing the photo_url field, which sits at numnber 5. Without this, there was no way to get the photo_url except during log in. Now we can grab it any time, along with their other profile data.
This is a required field for LogoutRequest to work properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add photo_url to UserProfileData proto
When fetching a user’s profile with GetUserProfileRequest, the resulting data object is different from the UserData object we get from Log in.
Our proto was missing the photo_url field, which sits at numnber 5.
Without this, there was no way to get the photo_url except during log in. Now we can grab it any time, along with their other profile data.
Add notification_device_token to LogoutRequest
This is a required field for LogoutRequest to work properly.