Chore: Upgrade Skeleton to Chakra v3 #1515
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunshamar
requested review from
Cmoen11,
leiferikbjorkli,
cibietici,
alicemacl,
mtdyrli,
mcklien and
Siljeelisestrm
and removed request for
a team
🦋 Changeset detectedLatest commit: b4f44fc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… with `loading` and updating `boxSize` to `size` in SkeletonCircle
alicemacl
reviewed
Feb 20, 2025
| }, | ||
| variant: { | ||
| pulse: { | ||
| background: "steel", |
There was a problem hiding this comment.
Vi må huske darkmode på denne, foreslår:
Suggested change
| background: "steel", | |
| background: { | |
| _light: "silver", | |
| _dark: "darkGrey", | |
| }, |
| shine: { | ||
| "--animate-from": "200%", | ||
| "--animate-to": "-200%", | ||
| "--start-color": "colors.lightGrey", |
There was a problem hiding this comment.
Suggested change
| "--start-color": "colors.lightGrey", | |
| "--start-color": { | |
| _light: "colors.lightGrey", | |
| _dark: "colors.dimGrey", | |
| }, |
| "--animate-from": "200%", | ||
| "--animate-to": "-200%", | ||
| "--start-color": "colors.lightGrey", | ||
| "--end-color": "colors.steel", |
There was a problem hiding this comment.
Suggested change
| "--end-color": "colors.steel", | |
| "--end-color": { | |
| _light: "colors.platinum", | |
| _dark: "colors.darkGrey", | |
| }, |
Comment on lines
+48
to
+51
| defaultVariants: { | ||
| variant: "pulse", | ||
| loading: true, | ||
| }, |
There was a problem hiding this comment.
Dette må slettes. Det er en bug at andre varianter arver verdier fra default variant. Definer det heller i props
| export const Skeleton = forwardRef<HTMLDivElement, SkeletonTextProps>( | ||
| function SkeletonText(props, ref) { | ||
| const recipe = useRecipe({ recipe: skeletonRecipe }); | ||
| const [recipeProps, restProps] = recipe.splitVariantProps(props); |
There was a problem hiding this comment.
Usikker på om denne trengs, eller om du bare kan legge props i recipe?
| return ( | ||
| <Circle size={size} asChild ref={ref}> | ||
| <ChakraSkeleton {...rest} /> | ||
| <ChakraSkeleton {...rest} loading={false} css={styles} /> |
There was a problem hiding this comment.
Jeg får error på loading her, noe type mismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Upgrading to chakra 3 breaks default styling applied, so created a recipe.
Solution
Chakra update checklist
UU checks