-
Notifications
You must be signed in to change notification settings - Fork 2.6k
chore(repo): enable v8 serializer #33286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
✅ Deploy Preview for nx-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 28819be
☁️ Nx Cloud last updated this comment at |
da4fee3 to
428b3c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nx Cloud has identified a possible root cause for your failed CI:
The PR changes were minimal and did not modify any application or test code:
- Deleted the .local.env file which contained NX_USE_V8_SERIALIZER=false
- Incremented the "bust" value from 3 to 4 in nx.json (a cache-busting configuration)
The test failures in e2e-next:e2e-ci--src/next-generation.test.ts were not caused by these changes. The root cause was an environment state issue where the local npm registry at http://localhost:4873 could not serve the "wildcard" package dependency.
The error "ERR_PNPM_FETCH_404 GET http://localhost:4873/wildcard: Not Found - 404" indicates that when pnpm tried to install @nx/[email protected] and @nx/[email protected], it encountered a missing transitive dependency. The wildcard package (required by [email protected], which is a dependency of @nx/next) was not available in the local registry.
This failure occurred during test setup in the packageInstall function at ../utils/create-project-utils.ts:464:29, before any test logic executed. The subsequent TypeError about "Cannot read properties of undefined (reading 'originalEnv')" was a cascading failure that happened during test teardown when resetNextEnv tried to access the setup object that was never successfully created.
Since the PR only modified configuration metadata (cache bust value) and removed an environment variable file unrelated to the wildcard package or npm registry configuration, the test failures were caused by the state of the test environment (specifically the local npm registry's package availability) rather than the code changes themselves.
A code change would likely not resolve this issue, so no action was taken.
🎓 To learn more about Self Healing CI, please visit nx.dev
428b3c5 to
28819be
Compare
Current Behavior
The V8 serializer was previously disabled via
.local.envfile settingNX_USE_V8_SERIALIZER=false.Expected Behavior
With this change, the V8 serializer is now enabled by removing the
.local.envfile that was disabling it. This allows Nx to use the V8 serializer for improved performance in task serialization.Related Issue(s)
This is a repository configuration update to enable the V8 serializer.