-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(nx-dev): add GitHub stars count to header #33224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👷 Deploy request for nx-docs pending review.Visit the deploys page to approve it
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@barbados-clemens @FrozenPandaz @jaysoo Please have a look :) |
|
View your CI Pipeline Execution ↗ for commit b29b613
☁️ Nx Cloud last updated this comment at |
|
Hey @DipakHalkude sorry for the late reply here, but yeah style looks good. like @julekgwa mentioned if we can get the live value so we don't have to maintain the value. the data should already be in the content collection since we fetch the plugin stats for the nx repo. logic is in the plugin.loader.ts. but should be able to get the nx overview entry in the header component. you can use the largeNumberFormatter from the formatters.ts file to format the value. as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style looks fine just want to make it dynamic so we don't need to manually update the value
|
Ok I am on it :) |
- Replace hardcoded '27.2k' with dynamic star count from GitHub API - Use inline formatter function to respect monorepo boundaries - Fetch real-time stargazers count from nrwl/nx repository
|
@barbados-clemens Please have a look :) |
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com>
|
Done from my side :) Thank you for the suggestion @barbados-clemens @julekgwa |
|
We can remove the second one as when we are clicking on any of the button it goes to github repo only. So we can remove the 2nd one |
|
@juristr What you think? We can remove this one! |
|
@juristr I guess now the implementation looks great :) |
|
@juristr @barbados-clemens Can someone review this :) |

Description
This PR adds a GitHub stars count button to the Nx marketing site header to showcase the project's community traction and provide social proof.
Changes
Implementation Details
Benefits
Testing
Closes #33028