fix(remix): update setup-tailwind generator to correct import statements #30599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ndcunningham
force-pushed
the
fix/remix-ts-solution-tailwind
branch
from
3526072 to
be40420
Compare
Contributor
|
View your CI Pipeline Execution ↗ for commit 93b2be7.
☁️ Nx Cloud last updated this comment at |
isaacplmann
approved these changes
Apr 2, 2025
Hardanish-Singh
approved these changes
Apr 17, 2025
jaysoo
reviewed
May 26, 2025
packages/remix/src/generators/setup-tailwind/__snapshots__/setup-tailwind.impl.spec.ts.snap
Outdated
Show resolved
Hide resolved
ndcunningham
force-pushed
the
fix/remix-ts-solution-tailwind
branch
from
be40420 to
93b2be7
Compare
Coly010
approved these changes
Jun 2, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Jun 3, 2025
…nts (#30599) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> There are two issues when we generate a remix application with ts solutions: 1. Running the `setup-tailwind` generator with a reference project which now is commonly with the pattern `@nx/acme` throws an error based on the schema. ``` Property 'project' does not match the schema.'@nx/acme' should match the pattern '^[a-zA-Z].*$'. ``` 2. The `tailwind.css` inside of `root.tsx` causes error with Vite. ``` app/root.tsx (9:7): "default" is not exported by "app/tailwind.css", imported by "app/root.tsx". ``` ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> The remix project should be able to be referenced similarly to how we handle React. The tailwind import should not throw an error. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #30343 (cherry picked from commit d87f4c2)
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
There are two issues when we generate a remix application with ts solutions:
setup-tailwindgenerator with a reference project which now is commonly with the pattern@nx/acmethrows an error based on the schema.tailwind.cssinside ofroot.tsxcauses error with Vite.Expected Behavior
The remix project should be able to be referenced similarly to how we handle React.
The tailwind import should not throw an error.
Related Issue(s)
Fixes #30343