fix(cache): display server-provided skipped message#113
Open
Conversation
Use the new `skipped_message` field from the StoreResponse proto when available, falling back to the existing hardcoded message for backward compatibility with older controllers.
|
View your CI Pipeline Execution ↗ for commit 9f56619
☁️ Nx Cloud last updated this comment at |
Document that cache writes require read-write tokens, and that read-only tokens on PRs are expected — cache entries are written by main branch workflows and restored on PRs.
rarmatei
approved these changes
Mar 13, 2026
Rewrite base-branch section to reflect that PR branches typically use read-only tokens and cannot write to cache. Consolidate with the cache writes section to avoid duplication. Add note about using read-write tokens on non-protected branches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skipped_messagefield (proto field 3) toStoreResponsein the cache step's generated protopost.tsto displayskippedMessagefrom the server when present, falling back to the existing hardcoded message for backward compatibilityContext
The workflow controller is being updated (nrwl/ocean CLOUD-4366) to return specific skip reasons via
skipped_message— e.g. distinguishing between lock contention and permission errors (403). Without this change, a 403 would show "another instance has already started the upload" which is misleading.Test plan
skippedMessagewhen presentskippedMessageis empty (older controller)