Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

#320 (relative image paths) seems to have regressed #437

Open
Qix- opened this issue Dec 31, 2018 · 1 comment
Open

#320 (relative image paths) seems to have regressed #437

Qix- opened this issue Dec 31, 2018 · 1 comment

Comments

@Qix-
Copy link

Qix- commented Dec 31, 2018

#320, which supposedly fixed relative image links, seems to have regressed. Apparently it's been like this for some time.

That, or the npm website isn't using marky correctly.

https://npmjs.org/package/chalk

image

Further, is there any reason why you're using using Regex to parse HTML?

@M-jerez
Copy link

M-jerez commented Jul 5, 2023

There seem to be an issue when using the picture and source tags as well.

  <picture>
    <source media="(prefers-color-scheme: dark)" srcset="./assets/public/logo-dark.svg?raw=true">
    <source media="(prefers-color-scheme: light)" srcset="./assets/public/logo.svg?raw=true">
    <img alt='mion, a mikro kit for Typescript Serverless APIs' src='./assets/public/logo.svg?raw=true' width="403" height="150">
  </picture>

This is mostly done so image looks good both in npm and github as the later uses dark color scheme by default.
Npm pacakge: https://www.npmjs.com/package/@mionkit/router
Github repo: https://github.com/MionKit/mion/tree/master/packages/router

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants