-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deps updates #8207
Merged
Merged
Deps updates #8207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wraithgar
commented
Apr 3, 2025
- deps: [email protected]
- deps: [email protected]
- deps: [email protected]
- deps: [email protected]
- chore: dev dependency updates
a577463
to
92e3cf5
Compare
92e3cf5
to
8f7683c
Compare
This comment was marked as spam.
This comment was marked as spam.
Okay! I was able to validate that the change of 41/42 packages installed was in fact from the optional dependency change (failing in latest). I'm surprised the smoke test didn't run against that PR? In any case, this is the after and before of the logs: These exactly account for the number change, so the number change is correct ( I counted the number of |
dfdb3d0
to
2196eac
Compare
This comment was marked as spam.
This comment was marked as spam.
nishantms
approved these changes
Apr 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.