Fix: use hash for big tx on verify (#1006)

novasamatech · Aug 4, 2023 · 3d83345 · 3d83345
1 parent fde3ee9
commit 3d83345
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/renderer/services/transaction/common/types.ts b/src/renderer/services/transaction/common/types.ts
@@ -30,7 +30,7 @@ export type ITransactionService = {
   getTransactionDeposit: (threshold: Threshold, api: ApiPromise) => string;
   getTransactionHash: (transaction: Transaction, api: ApiPromise) => HashData;
   decodeCallData: (api: ApiPromise, accountId: Address, callData: CallData) => DecodedTransaction;
-  verifySignature: (payload: string | Uint8Array, signature: HexString, accountId: AccountId) => Boolean;
+  verifySignature: (payload: Uint8Array, signature: HexString, accountId: AccountId) => Boolean;
 };
 
 // =====================================================

diff --git a/src/renderer/services/transaction/transactionService.ts b/src/renderer/services/transaction/transactionService.ts
@@ -12,7 +12,7 @@ import {
   UnsignedTransaction,
 } from '@substrate/txwrapper-polkadot';
 import { Weight } from '@polkadot/types/interfaces';
-import { signatureVerify } from '@polkadot/util-crypto';
+import { blake2AsU8a, signatureVerify } from '@polkadot/util-crypto';
 
 import { AccountId, HexString, Threshold } from '@renderer/domain/shared-kernel';
 import { Transaction, TransactionType } from '@renderer/domain/transaction';
@@ -440,8 +440,10 @@ export const useTransaction = (): ITransactionService => {
       });
   };
 
-  const verifySignature = (payload: string | Uint8Array, signature: HexString, accountId: AccountId): Boolean => {
-    return signatureVerify(payload, signature, accountId).isValid;
+  const verifySignature = (payload: Uint8Array, signature: HexString, accountId: AccountId): Boolean => {
+    const payloadToVerify = payload.length > 256 ? blake2AsU8a(payload) : payload;
+
+    return signatureVerify(payloadToVerify, signature, accountId).isValid;
   };
 
   return {