Polish optional FastAPI addon docs and packaging - #87
Conversation
There was a problem hiding this comment.
💡 Codex Review
Lines 77 to 85 in 34ddfe1
api extra
The updated docs instruct users to install the API layer via pip install "crapssim[api]", but the packaged project does not expose an api extra—setup.cfg only defines a testing extra and the repository has no build configuration that consumes pyproject.toml’s project.optional-dependencies. Running the advertised command against the released wheel or a local checkout therefore raises ExtrasRequirementError: crapssim 0.x has no such extra 'api', leaving the API addon impossible to install as described. Either add an api extra to the packaging metadata or revert the documentation to a working install path.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
apiextra while keeping the FastAPI layer opt-in[api]install, run, and curl guidanceTesting
PYTHONPATH=. pytest -qCodex Task