Skip to content

Conversation

@uglyoldbob
Copy link

This pull request updates the winit dependency to 0.29.15 and fixes things that broke.

@notgull notgull self-requested a review May 17, 2024 21:38
Copy link
Owner

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the warnings that appear.

warning: unused import: `std::os::raw`
  --> src/platform/x11.rs:29:5
   |
29 | use std::os::raw;
   |     ^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused import: `XVisualID`
  --> src/platform/x11.rs:32:76
   |
32 | use winit::platform::x11::{EventLoopBuilderExtX11 as _, WindowExtX11 as _, XVisualID};
   |                                                                            ^^^^^^^^^

warning: unused import: `WindowExtX11`
  --> src/platform/x11.rs:32:57
   |
32 | use winit::platform::x11::{EventLoopBuilderExtX11 as _, WindowExtX11 as _, XVisualID};
   |                                                         ^^^^^^^^^^^^

warning: unused import: `WindowExtWayland`
  --> src/platform/wayland.rs:32:68
   |
32 |     EventLoopBuilderExtWayland as _, WindowBuilderExtWayland as _, WindowExtWayland as _,
   |                                                                    ^^^^^^^^^^^^^^^^

warning: unused variable: `code`
   --> src/filter.rs:244:21
    |
244 |         if let Some(code) = self.reactor.exit_requested() {
    |                     ^^^^ help: if this is intentional, prefix it with an underscore: `_code`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: struct `CallOnDrop` is never constructed
   --> src/handler.rs:540:8
    |
540 | struct CallOnDrop<F: FnMut()>(F);
    |        ^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: method `pop` is never used
   --> src/sync.rs:557:12
    |
550 |     pub trait ConcurrentQueue<T> {
    |               --------------- method in this trait
...
557 |         fn pop(&self) -> Option<T>;
    |            ^^^

warning: trait `EventLoopPrivate` is never used
   --> src/platform.rs:110:19
    |
110 |         EventLoop EventLoopPrivate
    |                   ^^^^^^^^^^^^^^^^
    |
    = note: this warning originates in the macro `sealed_trait_with_gen` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: `async-winit` (lib) generated 28 warnings (run `cargo fix --lib -p async-winit` to apply 2 suggestions)
warning: unused `Result` that must be used
   --> examples/window.rs:36:5
    |
36  | /     evl.block_on(async move {
37  | |         // Wait for a resume event to start.
38  | |         target.resumed().await;
...   |
102 | |         target.exit().await
103 | |     });
    | |______^
    |
    = note: this `Result` may be an `Err` variant, which should be handled
    = note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
    |
36  |     let _ = evl.block_on(async move {
    |     +++++++

warning: `async-winit` (example "window") generated 1 warning
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 44.89s
     Running `target/debug/examples/window`

@uglyoldbob uglyoldbob marked this pull request as draft May 20, 2024 18:45
@notgull
Copy link
Owner

notgull commented May 21, 2024

For reference, I was planning on doing the porting work myself once winit stabilized and stopped having these frequent breaking changes. The current plan is that v0.31 should be relatively stable, but I wasn't about to hold my breath.

@uglyoldbob
Copy link
Author

Ah that makes sense. I wanted to experiment with making an async version of egui and wanted something compatible with winit 0.29.15 to mess around with.

@uglyoldbob uglyoldbob marked this pull request as ready for review June 3, 2024 22:35
@uglyoldbob
Copy link
Author

I have this ready for review. @notgull

@uglyoldbob uglyoldbob requested a review from notgull June 6, 2024 17:24
@notgull
Copy link
Owner

notgull commented Jun 7, 2024

It looks like my CI instance crashed, let me see if I can bring it back up...

@notgull
Copy link
Owner

notgull commented Jun 7, 2024

Good news! My CI instance is back up. Bad news! Previously I had it on a physical server, but now that's not possible so I've have it hosted now on a AWS EC2 instance with one core. Bummer, and it looks like I've built up a backlog. How big is it?

image

Oh no!

Well, give me some time here. It might be a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants