-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIP-84: Highlights #501
NIP-84: Highlights #501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we already have a NIP for bookmarks (other than e
lists)? This seems like a more granular form of the same thing. Fully support it though.
84.md
Outdated
[ "range", 42, 84, "context" ] # highlight begins at index position 42 of the `context` tag's value | ||
``` | ||
|
||
#### Non-text-based nostr events's highlights |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
events'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
damn it! 😂 thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You missed a chance to use the most amazing feature of the English language.
Clients MAY include a `context` tag, useful when the highlight is a subset of a paragraph and displaying the | ||
surrounding content might be beneficial to give context to the higlight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe clarify that this is a larger text excerpt of the original content, that wasn't immediately obvious to me. Or just refer to the example below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yeah, good point
#### Non-text-based nostr events's highlights | ||
|
||
A `kind:9802` event that tags a NIP-94 event which includes a video or audio file can use ranges to | ||
indicate the start/end time position in seconds. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include a tag that marks the highlight as audio/video? It seems to me that audio/video refs could be r
(youtube link), a
(replaceable event representing a track) or e
(NIP-94 audio/video file).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pablof7z can you answer this?
|
Next release of Coracle will have support for rendering highlights. |
[ "p", "...", "author" ], | ||
[ "p", "...", "author" ], | ||
[ "p", "...", "editor" ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ "p", "...", "author" ], | |
[ "p", "...", "author" ], | |
[ "p", "...", "editor" ], | |
[ "p", "...", "<recommended relay URL>", "author" ], | |
[ "p", "...", "<recommended relay URL>", "author" ], | |
[ "p", "...", "<recommended relay URL>", "editor" ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pablof7z please ack here.
`a` or `e` tags should be used for nostr events and `r` tags for URLs. | ||
|
||
When tagging a URL, clients generating these events SHOULD do a best effort of cleaning the URL from trackers | ||
or obvious non-useful information from the query string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is a good idea to say that r
urls should remove trailing slash so to ease querying.
So https://footstr.com/zapvertise/ -> https://footstr.com/zapvertise
And https://example.com/?article=987 -> https://example.com?article=987
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And also normalize/sort the query strings, remove the #
section, port names, prefer https?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. Remove port if 80 (http) or 443 (https) only.
Is this a thing? I think I missed this NIP entirely. |
with support on amethyst, highlighter, habla and soon(TM) coracle 😉 |
Is the NIP number a reference to some historical event? |
haha, no, this one is random and has no special meaning 😅 |
Co-authored-by: Alejandro <[email protected]>
Co-authored-by: Alejandro <[email protected]>
Co-authored-by: arthurfranca <[email protected]>
Co-authored-by: arthurfranca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented support for this in Coracle yesterday, one thing I'd like to see is an alt/summary/comment tag that allows people to leave a note about the highlight (like a quote tweet). I left a note on highlighter about a highlight, but it didn't show up on the event itself.
Any specific reason why this is not merged yet? |
I need to update some stuff based on comments but totally forgot; I'll do it soon so we can merge |
I do this with a kind 1 quoting the kind 9802. |
Does the spec allow for combination of a quote note (I believe this is 'q' tag x NIP-18) functionality + highlight functionality? For instance, if I quote a few words from a note, does NIP-84 specify a way to combine quote note functionality that I can display with the highlight, so that I can add my commentary to the highlight? Example mockup: cc @ericholguin |
quote highlights are kind:1s that |
This NIP introduces
kind:9802
Highlight event as implemented by https://highlighter.com and https://habla.newskind:9802
events are highlights of nostr events'content
(e.g.,kind:1
orkind:30023
) or URLs, signaling content of importance to a user.NIP text: https://github.com/pablof7z/nips/blob/highlights/84.md
@fiatjaf @verbiricha