Skip to content

Conversation

@SpoonOne
Copy link

No description provided.

@ghost
Copy link

ghost commented Feb 22, 2024

Thank you for your contribution, can you please also add the required module tests?

I currently lack the technical means to do local puppet development due to a reinstallation of the workstation.

@SpoonOne
Copy link
Author

I'll give it a go when I have the time. From my brief look it appears there might be missing tests for existing options as it is but I'll just look to add the tests for the ones I added/changed.

@ghost
Copy link

ghost commented Feb 26, 2024

I had to merge an upgrade to PDK 3.x in #64. Please fetch those changes first, before you try to add more tests.

On my Ubuntu 22.04 LTS, pdk 2.x wasn't able to successfully install module dependencies. After that I had to migrate concat to 4.1.0 to be compatible again (is_string, unknown function).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant