Skip to content

CI | Warp run action on Containerized and Non Containerized deployments #9033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented May 20, 2025

Describe the Problem

Warp is a tool used for S3 benchmarking, we would like to run it as part of NooBaa CI actions.

Explain the Changes

  1. Created 2 new github actions that run make-warp and make-nc-warp targets.
  2. Created 2 new makefile targets called make-warp and make-nc-warp that build noobaa tester image and run warp on Containerized/Non Containerized setups.
  3. Added Containerized/Non Containerized setups, warp deployments, configurations and a run of run_warp.js tool.
  4. Added run_warp.js tool that runs warp directed to NooBaa.
  5. Added documentation.

Issues: Fixed #xxx / Gap #xxx

  1. Gap - Add to run_warp usage of --benchdata so we can put in our logs the csv created on warp runs.
  • Doc added/updated

@romayalon romayalon marked this pull request as ready for review May 20, 2025 09:25
@romayalon romayalon force-pushed the romy-ci-warp-action branch 2 times, most recently from 8abfc27 to 72ced52 Compare May 20, 2025 09:49
@romayalon romayalon requested a review from nadavMiz May 20, 2025 12:56
@romayalon romayalon force-pushed the romy-ci-warp-action branch from 72ced52 to 8a92df7 Compare May 20, 2025 15:24
@nimrod-becker
Copy link
Contributor

Looks good.
We talked about saving the output to the artifactory with a 24h retention, which you mentioned you want to add.

We also talked about breaking Makefile into, at least Makefile and Makefile.test but we don't have to take care of it now, we can open a gap in our backlog

@nimrod-becker
Copy link
Contributor

@nadavMiz notice that after this action is merged we'll also need this one using the changes you are working on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants