Fix is_grapheme_boundary panic on empty rope
#24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`unwrap()` at `src/rope/utils.rs:172`: https://github.com/nomad/crop/blob/ae8ac1669e1024df42b18ec3e26c3f8d933cebc2/src/rope/utils.rs#L172 If the rope is empty, the `chunks` iterator won't yield any items. We can avoid hitting this case, and do less work, if we recognize that an empty rope has one valid grapheme boundary, at byte offset 0.
noib3
reviewed
Mar 13, 2025
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
...from the assert above.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unwrap()atsrc/rope/utils.rs:172:crop/src/rope/utils.rs
Line 172 in ae8ac16
If the rope is empty, the
chunksiterator won't yield any items. We can avoid hitting this case, and do less work, if we recognize that an empty rope has one valid grapheme boundary, at byte offset 0.