Cleanup GPU and NPU utility code #479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen that you added NPU monitoring capabilities to Resources and wanted to check out the code. I also looked into PR #431.
I think that the code becomes "simpler" by using dynamic dispatch using
Derefon theGpuandNputypes. This required me to make theGpuImplandNpuImpltraits object-safe and I had to move the genericread_sysfs_int/read_sysfs_file/read_device_int/read_hwmon_intfunctions out of theGpuImplandNpuImpltraits. I consolidated these in a newread_sysfsfunction insrc/utils/mod.rs.I also refactored some code to cut down on some of the
PathBufandStringallocations where not necessary.While building the code using
flatpak-builderI ran into timeouts ondmidecode. I've changed the download URL from thegit.savannah.nongnu.org/cgitendpoint todownload-mirror.savannah.gnu.org, which should be much faster.