Skip to content

WIP: Kconfig#3138

Closed
nwf wants to merge 2 commits intonodemcu:devfrom
nwf:kconfig
Closed

WIP: Kconfig#3138
nwf wants to merge 2 commits intonodemcu:devfrom
nwf:kconfig

Conversation

@nwf
Copy link
Copy Markdown
Member

@nwf nwf commented May 31, 2020

WIP on #3130

  • Define Kconfig files for user_modules.h
  • Define Kconfig files for most of user_config.h
  • Deal with the rest of user_config.h
  • Wire up .config generation
  • Replace use of CPP symbols with Kconfig symbols
  • user_mbedtls.h ?
  • user_modules.h -> .config script?
  • cloud builder

I will eagerly accept help on any of this. :)

  • This PR is for the dev branch rather than for master.
  • This PR is compliant with the other contributing guidelines as well (if not, please describe why).
  • I have thoroughly tested my contribution.
  • The code changes are reflected in the documentation at docs/*.

@nwf nwf requested a review from jmattsson May 31, 2020 15:06
Comment thread app/Kconfig.user
@@ -0,0 +1,289 @@
menu "Global Configuration Parameters"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I please suggest that this goes into the components/platform/Kconfig to match the esp32 branch? And we probably include the word "NodeMCU" in the menu name to make it easier to spot among the IDF things (especially on the esp32 IDF these days).

@stale
Copy link
Copy Markdown

stale Bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Apr 16, 2022
@stale stale Bot closed this Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants