Skip to content

feat(ci): notify on push to main #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2025
Merged

Conversation

avivkeller
Copy link
Member

We need to enable the merge queue for this to work.

@avivkeller avivkeller requested a review from a team as a code owner July 18, 2025 18:40
@bmuenzenmeyer
Copy link

bmuenzenmeyer commented Jul 18, 2025

we need the openjs foundation to create a new SLACK_WEBHOOK for us - this is a repository secret (grumble grumble monorepo)

@AugustinMauroy
Copy link
Member

why flaky didn't have the green approve ?

@avivkeller
Copy link
Member Author

why flaky didn't have the green approve ?

We shouldn't either. Only Claudio and Brian should. It's being discussed in admin.

@avivkeller avivkeller added this pull request to the merge queue Jul 21, 2025
Merged via the queue into main with commit a5a5150 Jul 21, 2025
4 checks passed
@avivkeller avivkeller deleted the ci/notify-on-main-push branch July 21, 2025 22:32
@avivkeller avivkeller mentioned this pull request Jul 21, 2025
@avivkeller
Copy link
Member Author

(Merged without the secret, assuming that no one plans to push directly to main anytime soon, given the protections we have in place)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants