Skip to content

Add web-infra onboarding docs #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add web-infra onboarding docs #17

wants to merge 4 commits into from

Conversation

flakey5
Copy link
Member

@flakey5 flakey5 commented Jul 13, 2025 •
edited
Loading

Re #5

Note: blocked until nodejs/admin#984 goes through since this mentions the web-admins team.

@flakey5 flakey5 requested a review from a team as a code owner July 13, 2025 18:12
flakey5
flakey5 commented Jul 13, 2025
View reviewed changes
avivkeller
avivkeller reviewed Jul 13, 2025
View reviewed changes
Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps make an ONBOARDING.md, with a # @nodejs/web-infra section?

@ovflowd
Copy link
Member

ovflowd commented Jul 14, 2025

@flakey5 I also believe we could document our Slack channels on the onboarding doc and what they server for. (there's the website one, alerts one, i18n one for website, and others I gues?)

@avivkeller avivkeller mentioned this pull request Jul 14, 2025
Merged
@ovflowd
Copy link
Member

ovflowd commented Jul 14, 2025

OOC, why is the PR blocked?

@ovflowd
Copy link
Member

ovflowd commented Jul 14, 2025

@flakey5 I forgot, we also have this list for Crowdin: https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L175

Can you also add this to the onboarding docs, we also need the current remaining members of web-infra added there!

@ovflowd
Copy link
Member

ovflowd commented Jul 14, 2025

Same for: https://github.com/nodejs/email/blob/main/iojs.org/aliases.json#L241

@avivkeller
Copy link
Member

OOC, why is the PR blocked?

Per the PR description,

Note: blocked until nodejs/admin#984 goes through since this mentions the web-admins team.

MattIPv4
MattIPv4 reviewed Jul 16, 2025
View reviewed changes
@flakey5 @avivkeller @MattIPv4
Apply suggestions from code review
adaaff6 
Co-authored-by: Aviv Keller <[email protected]>
Co-authored-by: Matt Cowley <[email protected]>
@ovflowd
Copy link
Member

ovflowd commented Jul 26, 2025

Hey @flakey5 just wondering if you're still OOO (vacations); Should we take over this PR or?

@flakey5
review
2dc9f13 
Signed-off-by: flakey5 <[email protected]>
@flakey5
Copy link
Member Author

flakey5 commented Jul 27, 2025

just wondering if you're still OOO (vacations); Should we take over this PR or?

Apologizes got side tracked, updated from reviews but I think this should still be blocked since nodejs/admin#984 is still open

@flakey5 flakey5 mentioned this pull request Jul 27, 2025
Open
@avivkeller avivkeller requested a review from a team July 29, 2025 00:58
@avivkeller

This comment was marked as resolved.

Sign in to view
@avivkeller avivkeller mentioned this pull request Jul 29, 2025
Open
2 tasks
@ovflowd
Copy link
Member

ovflowd commented Jul 29, 2025

just wondering if you're still OOO (vacations); Should we take over this PR or?

Apologizes got side tracked, updated from reviews but I think this should still be blocked since nodejs/admin#984 is still open

Agreed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 left review comments

@avivkeller avivkeller avivkeller left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
blocked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flakey5 @ovflowd @avivkeller @MattIPv4