-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[actions] use ljharb/actions/node/matrix #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! BTW that cool action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
w00t! Thanks for this 🙏
This reverts commit eef8d21.
@ljharb something in here causes CI to fail on globs (ex https://github.com/nodejs/userland-migrations/actions/runs/12068897635/job/33654997438) |
@JakobJingleheimer rather than reverting, it might be more helpful to print out |
https://github.com/nodejs/userland-migrations/actions/runs/12068897635/job/33654997438#step:3:9 says it installed Node.js 20.18.1 |
Ah, yes. I reverted because I think this is super cool but non-blocking. Since the parent PR is otherwise ready to go, I think we can figure this out and then as a subsequent enhancement. And the other landed, I think this will be easier to test 🙂 |
(into #1)