feat(outgoingmessage-headers) #281
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
No need to ping me, I receive notification for all thing on the repo |
Member
AugustinMauroy
left a comment
AugustinMauroy
left a comment
There was a problem hiding this comment.
Not too bad there are some pont that you can improve 👍
| @@ -0,0 +1,22 @@ | |||
| schema_version: "1.0" | |||
| name: "@nodejs/outgoingmessage-headers" | |||
Member
There was a problem hiding this comment.
Suggested change
| name: "@nodejs/outgoingmessage-headers" | |
| name: "@nodejs/http-outgoingmessage-headers" |
not fan of the name but my proposition did look right @nodejs/userland-migrations any idea ?
| export default function transform(root: SgRoot<Js>): string | null { | ||
| const rootNode = root.root(); | ||
| const edits: Edit[] = []; | ||
| let hasChanges = false; |
Member
There was a problem hiding this comment.
Suggested change
| let hasChanges = false; |
Comment on lines
+88
to
+89
| if (!hasChanges) return null; | ||
| return rootNode.commitEdits(edits); |
Member
There was a problem hiding this comment.
Suggested change
| if (!hasChanges) return null; | |
| return rootNode.commitEdits(edits); | |
| if (!edits.lenght) return null; | |
| return rootNode.commitEdits(edits); |
the hasChanges logic isn't needed.
| const matches = rootNode.findAll({ | ||
| rule: { pattern: "$OBJ._headers[$KEY]" }, | ||
| }); | ||
| for (const m of matches) { |
Member
There was a problem hiding this comment.
Suggested change
| for (const m of matches) { | |
| for (const m of matches) { |
|
|
||
| { | ||
| const matches = rootNode.findAll({ | ||
| rule: { pattern: "$OBJ._headers[$KEY]" }, |
Member
There was a problem hiding this comment.
main part here...
Here if the user code have ah propriety expression _headers it's will be catch. We need a more complex logic to catch http usage and -> catch response objects -> catch _headers
I have to admit that the orignal issue examples wasn't 100% complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, @AugustinMauroy
Here's a draft. I'd like to know if I'm on the right track. There are some things missing, like the README, but I'll add them. Thx
issue: #128