feat(process-assert-to-node-assert): introduce

[matheusmorett2]

Closes #197

Add codemod recipe process-assert-to-assert to handle deprecation DEP0100.

Before

const { assert: nodeAssert, env } = require("process");
nodeAssert(condition, "Assertion valid");

After

const assert = require("node:assert");
const { env } = require("process");
assert(condition, "Assertion valid");

---

Fix: remove-binding.ts

handle scenario where have alias in require

[AugustinMauroy]

I didn't see any test for that kind cases

import process from "node:process"

But good first pr

[brunocroh]

Awesome first contribution 🎉, Thank you @matheusmorett2 !

Just small fixes needed

[brunocroh]

Please fix the conflict in the remove-binding file

[AugustinMauroy]

For require call not in cjs context the transformed code may be wrong.

For example this before

import { createRequire} from 'node:module';
const require = createRequire(import.meta.dirname)

process.assert(true);

Broken after with the current implementation

const assert = require('node:assert');
import { createRequire} from 'node:module';
const require = createRequire(import.meta.dirname)

assert(true);

In this case I expect that require is undefined.

Solutions:

1. Try to found a logic that handle that.
2. Add it at inline comment so we know for the future

[AugustinMauroy]

hey @matheusmorett2 any news on this pr ?

[avivkeller]

I think this could use some refactoring. There's a lot of nesting, among other things.

Can you break it up, and look at the other mods for inspiration?

[AugustinMauroy]

bump @matheusmorett2

[AugustinMauroy]

Oh fuck ci is red for strange post script strange

[JakobJingleheimer]

Thanks for this! It's looking pretty good :)

[JakobJingleheimer]

This has some changes that I think should not be here.

[JakobJingleheimer]

It may not need to do that: node:module.findPackageJSON()

[JakobJingleheimer]

I think you also need getNodeImportCalls (from the same util as getNodeImportStatements) to handle dynamic imports.

[JakobJingleheimer]

It's kind of weird to set and then immediately overwrite the variable.

Suggested change

	let sourceCode = rootNode.commitEdits(edits);
	sourceCode = removeLines(sourceCode, linesToRemove);
	const sourceCode = removeLines(
	rootNode.commitEdits(edits),
	linesToRemove,
	);

[JakobJingleheimer]

Suggested change

	if (alreadyRequiringAssert.length || alreadyImportingAssert.length)
	return sourceCode;
	if (alreadyRequiringAssert.length || alreadyImportingAssert.length) return sourceCode;

[JakobJingleheimer]

Since node supports typescript by default now, I think this should handle that too:

Suggested change

	const isCjsFile = filename.endsWith('.cjs');
	const isMjsFile = filename.endsWith('.mjs');
	const isCjsFile = filename.endsWith('.cjs') || filename.endsWith('.cts');
	const isMjsFile = filename.endsWith('.mjs') || filename.endsWith('.mts');

[JakobJingleheimer]

There's a more robust builtin way to find the package.json: module.findPackageJSON()

[JakobJingleheimer]

I think since this check is last it should be okay: the migration has already determined that the file contents is ambiguous; this will forcibly disambiguate the file, but that's probably okay.

I think best to add a note around here though that the sequence of checks needs to stay:

1. pre-existing import statement(s)
2. pre-existing require() calls
3. authoritative file extension
4. pjson.type