feat: set VARIATION for rv64/pointer-compression to change tarball name#223
Merged
Conversation
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Signed-off-by: Stewart X Addison <sxa@ibm.com>
Signed-off-by: Stewart X Addison <sxa@ibm.com>
richardlau
approved these changes
Feb 26, 2026
Member
|
@sxa You may need to update https://github.com/nodejs/nodejs-dist-indexer/blob/main/src/transform-filename.js as well. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VARIATION wasn't configured in the original code which means that the tarball comes out as the same as the gcc/non-compressed version and so overwrites it. I wrongly expected that it would use the name of recipe. This change should force the alternate tarball name as is done for the x64-pointer-compression version. (A couple of other minor corrections included too)