fix: Fix typos #3985
Open
fix: Fix typos #3985
+15
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
approved these changes
Jan 2, 2025
Uzlopak
reviewed
Jan 2, 2025
| @@ -14,7 +14,7 @@ The `MemoryCacheStore` stores the responses in-memory. | |||
| **Options** | |||
|
|
|||
| - `maxCount` - The maximum amount of responses to store. Default `Infinity`. | |||
| - `maxEntrySize` - The maximum size in bytes that a response's body can be. If a response's body is greater than or equal to this, the response will not be cached. | |||
| - `maxEntrySize` - The maximum size in bytes that a response body can be. If a response body is greater than or equal to this, the response will not be cached. | |||
There was a problem hiding this comment.
Is this wording good? I mean: The maximum size that a body can have?
There was a problem hiding this comment.
I've never seen "response's body" in technical documents.
I need an LLM to argue.
There was a problem hiding this comment.
In the HTTP standard it is called "message body".
Uzlopak
reviewed
Jan 2, 2025
| @@ -26,7 +26,7 @@ The `SqliteCacheStore` is only exposed if the `node:sqlite` api is present. | |||
|
|
|||
| - `location` - The location of the SQLite database to use. Default `:memory:`. | |||
| - `maxCount` - The maximum number of entries to store in the database. Default `Infinity`. | |||
| - `maxEntrySize` - The maximum size in bytes that a resposne's body can be. If a response's body is greater than or equal to this, the response will not be cached. Default `Infinity`. | |||
| - `maxEntrySize` - The maximum size in bytes that a response body can be. If a response body is greater than or equal to this, the response will not be cached. Default `Infinity`. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found few misspellings.