Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support array of headers in WrapHandler #3941

Merged
merged 2 commits into from
Dec 11, 2024
Merged

support array of headers in WrapHandler #3941

merged 2 commits into from
Dec 11, 2024

Conversation

KhafraDev
Copy link
Member

fixes #3934

Uzlopak
Uzlopak previously requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid the excessive use of array helper Methods

mcollina
mcollina approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KhafraDev
Copy link
Member Author

@Uzlopak feel free to create a follow up PR

@KhafraDev KhafraDev merged commit d2b332a into nodejs:main Dec 11, 2024
29 of 31 checks passed
@KhafraDev KhafraDev deleted the issue-3934 branch December 11, 2024 14:45
This was referenced Dec 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metcoder95 metcoder95 metcoder95 approved these changes

@ronag ronag ronag approved these changes

@mcollina mcollina mcollina approved these changes

@Uzlopak Uzlopak Uzlopak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v7 RetryAgent converts header with multiple entries (eg. set-cookie) to \x00
5 participants
@KhafraDev @mcollina @ronag @Uzlopak @metcoder95