Skip to content

meta: upgrade to next.js 16 #8218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

meta: upgrade to next.js 16 #8218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
93b2097
meta: upgrade to next.js 16
ovflowd Oct 11, 2025
7a3a331
chore: added changed file
ovflowd Oct 11, 2025
74294f2
chore: forgot providers
ovflowd Oct 14, 2025
86b9ab7
fix: interesting workaround
ovflowd Oct 14, 2025
16c6f86
fix: interesting workaround
ovflowd Oct 14, 2025
a2a0132
chore: updated to Next.js 16 stable
ovflowd Oct 22, 2025
0f583df
chore: cleaned up withnoderelease
ovflowd Oct 22, 2025
1436185
fix: open-next build should be webpack
ovflowd Oct 28, 2025
da1f03f
chore: updated next and rebased
ovflowd Nov 14, 2025
f14629a
chore: need to use middleware.ts for now
ovflowd Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ package-lock.json
# Next.js Build Output
.next
build
next-env.d.ts

# Test Runner
junit.xml
Expand Down
11 changes: 5 additions & 6 deletions apps/site/app/[locale]/error.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use client';

import { ArrowRightIcon } from '@heroicons/react/24/solid';
import { useTranslations } from 'next-intl';
import type { FC } from 'react';

Expand All @@ -12,17 +11,17 @@ const ErrorPage: FC<{ error: Error }> = () => {

return (
<GlowingBackdropLayout kind="default">
500
<span>500</span>

<h1 className="special -mt-4 text-center">
{t('layouts.error.internalServerError.title')}
</h1>

<p className="-mt-4 max-w-sm text-center text-lg">
{t('layouts.error.internalServerError.description')}
</p>
<Button href="/">
{t('layouts.error.backToHome')}
<ArrowRightIcon />
</Button>

<Button href="/">{t('layouts.error.backToHome')}</Button>
</GlowingBackdropLayout>
);
};
Expand Down
6 changes: 1 addition & 5 deletions apps/site/app/[locale]/not-found.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
'use server';

import { ArrowRightIcon } from '@heroicons/react/24/solid';
import { getTranslations } from 'next-intl/server';
import type { FC } from 'react';

Expand All @@ -27,10 +26,7 @@ const NotFoundPage: FC = async () => {
{t('layouts.error.notFound.description')}
</p>

<Button href="/">
{t('layouts.error.backToHome')}
<ArrowRightIcon />
</Button>
<Button href="/">{t('layouts.error.backToHome')}</Button>
</GlowingBackdropLayout>
);
};
Expand Down
33 changes: 0 additions & 33 deletions apps/site/app/global-error.tsx
View file
Open in desktop

This file was deleted.

19 changes: 7 additions & 12 deletions apps/site/components/withNodeRelease.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,15 @@ type WithNodeReleaseProps = {
// Note that Hooks cannot be used in a RSC async component
// Async Components do not get re-rendered at all.
const WithNodeRelease: FC<WithNodeReleaseProps> = async ({
status,
status: statuses,
children: Component,
}) => {
const releaseData = await provideReleaseData();

let matchingRelease: NodeRelease | undefined;
for (const statusItem of Array.isArray(status) ? status : [status]) {
matchingRelease = releaseData.find(
release => release.status === statusItem
);
if (matchingRelease) {
break;
}
}
const releases = await provideReleaseData();

const matchingRelease = [statuses]
.flat()
.map(status => releases.find(release => release.status === status))
.find(Boolean);

if (matchingRelease) {
return <Component release={matchingRelease} />;
Expand Down
2 changes: 1 addition & 1 deletion apps/site/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export default baseConfig.concat([

react.configs.flat['jsx-runtime'],
hooks.configs['recommended-latest'],
next.flatConfig.coreWebVitals,
next.configs['core-web-vitals'],
mdx.flatCodeBlocks,

// Type-checking
Expand Down
2 changes: 1 addition & 1 deletion apps/site/next-env.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/// <reference types="next" />
/// <reference types="next/image-types/global" />
/// <reference types="next/navigation-types/compat/navigation" />
/// <reference path="./.next/types/routes.d.ts" />
import "./.next/types/routes.d.ts";

// NOTE: This file should not be edited
// see https://nextjs.org/docs/app/api-reference/config/typescript for more information.
10 changes: 5 additions & 5 deletions apps/site/next.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ import { redirects, rewrites } from './next.rewrites.mjs';

/** @type {import('next').NextConfig} */
const nextConfig = {
allowedDevOrigins: ['10.1.1.232'],
// Full Support of React 18 SSR and Streaming
reactCompiler: true,
// We don't want to redirect with trailing slashes
skipTrailingSlashRedirect: true,
// We allow the BASE_PATH to be overridden in case that the Website
Expand Down Expand Up @@ -50,10 +51,7 @@ const nextConfig = {
// Enable statically typed links
// @see https://nextjs.org/docs/app/api-reference/config/typescript#statically-typed-links
typedRoutes: true,
// We don't want to run ESLint Checking on Production Builds
// as we already check it on the CI within each Pull Request
// we also configure ESLint to run its lint checking on all files
eslint: { ignoreDuringBuilds: true },
// Experimental Flags
Copy link

Copilot AI Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ESLint configuration section and its comment have been removed entirely. This removes the eslint: { ignoreDuringBuilds: true } setting. Without this, ESLint will now run during production builds, which may cause build failures if there are any linting errors. Consider either:

  1. Keeping eslint: { ignoreDuringBuilds: true } if you still want to skip ESLint during builds
  2. Ensuring all ESLint errors are fixed before merging
  3. Documenting this intentional change if the goal is to enforce linting during builds

Copilot uses AI. Check for mistakes.
experimental: {
useCache: true,
// Ensure that server-side code is also minified
Expand All @@ -80,6 +78,8 @@ const nextConfig = {
'tailwindcss',
'shiki',
],
// Faster Development Servers with Turbopack
turbopackFileSystemCacheForDev: true,
},
// If we're building for the Cloudflare deployment we want to set
// an appropriate deploymentId (needed for skew protection)
Expand Down
6 changes: 2 additions & 4 deletions apps/site/open-next.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,9 @@ const cloudflareConfig = defineCloudflareConfig({ incrementalCache });

const openNextConfig: OpenNextConfig = {
...cloudflareConfig,
buildCommand: 'pnpm build:default',
buildCommand: 'pnpm build:default --webpack',
cloudflare: {
skewProtection: {
enabled: true,
},
skewProtection: { enabled: true },
},
};

Expand Down
19 changes: 10 additions & 9 deletions apps/site/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,17 @@
"type": "module",
"scripts": {
"prebuild": "node --run build:blog-data",
"build": "node --run build:default -- --turbo",
"build": "node --run build:default -- --turbopack",
"build:blog-data": "cross-env NODE_NO_WARNINGS=1 node ./scripts/blog-data/generate.mjs",
"build:blog-data:watch": "node --watch --watch-path=pages/en/blog ./scripts/blog-data/generate.mjs",
"build:default": "cross-env NODE_NO_WARNINGS=1 next build",
"cloudflare:build:worker": "OPEN_NEXT_CLOUDFLARE=true opennextjs-cloudflare build",
"cloudflare:deploy": "opennextjs-cloudflare deploy",
"cloudflare:preview": "wrangler dev",
"predeploy": "node --run build:blog-data",
"deploy": "cross-env NEXT_PUBLIC_STATIC_EXPORT=true node --run build:default -- --turbo",
"deploy": "cross-env NEXT_PUBLIC_STATIC_EXPORT=true node --run build:default -- --turbopack",
"predev": "node --run build:blog-data",
"dev": "cross-env NODE_NO_WARNINGS=1 next dev --turbo",
"dev": "cross-env NODE_NO_WARNINGS=1 next dev --turbopack",
"lint": "node --run lint:js && node --run lint:css && node --run lint:md",
"lint:fix": "node --run lint:js:fix && node --run lint:css:fix && node --run lint:md:fix",
"lint:css": "stylelint \"**/*.css\" --allow-empty-input --cache --cache-strategy=content --cache-location=.stylelintcache",
Expand Down Expand Up @@ -52,16 +52,16 @@
"@types/react": "catalog:",
"@vcarl/remark-headings": "~0.1.0",
"@vercel/analytics": "~1.5.0",
"@vercel/otel": "~2.0.1",
"@vercel/otel": "~2.1.0",
"@vercel/speed-insights": "~1.2.0",
"classnames": "catalog:",
"cross-env": "catalog:",
"feed": "~5.1.0",
"github-slugger": "~2.0.0",
"gray-matter": "~4.0.3",
"mdast-util-to-string": "^4.0.0",
"next": "15.5.4",
"next-intl": "~4.3.11",
"next": "16.0.3",
Copy link

Copilot AI Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is upgrading to [email protected], which appears to be a beta version (the PR description shows "Next.js 16.0.0-beta.0" in the build output). Using beta versions in production is risky as they may contain bugs or breaking changes. Consider:

  1. Waiting for a stable Next.js 16 release
  2. Thoroughly testing all functionality with this beta version
  3. Documenting known issues and limitations
  4. Having a rollback plan ready

Note: The build error shown in the PR description (Error [PageNotFoundError]: Cannot find module for page: /_document) suggests there may be breaking changes in error page handling that need to be addressed.

Suggested change
"next": "16.0.3",
"next": "16.0.0",

Copilot uses AI. Check for mistakes.
"next-intl": "~4.5.3",
"next-themes": "~0.4.6",
"postcss-calc": "~10.1.1",
"react": "catalog:",
Expand All @@ -81,16 +81,17 @@
},
"devDependencies": {
"@flarelabs-net/wrangler-build-time-fs-assets-polyfilling": "^0.0.1",
"@next/eslint-plugin-next": "15.5.4",
"@next/eslint-plugin-next": "16.0.3",
"@node-core/remark-lint": "workspace:*",
"@opennextjs/cloudflare": "^1.6.4",
"@opennextjs/cloudflare": "^1.12.0",
"@playwright/test": "^1.56.1",
"@testing-library/user-event": "~14.6.1",
"@types/mdast": "^4.0.4",
"@types/mdx": "^2.0.13",
"@types/semver": "~7.7.1",
"babel-plugin-react-compiler": "^1.0.0",
"dedent": "^1.7.0",
"eslint-config-next": "15.5.4",
"eslint-config-next": "16.0.3",
"eslint-plugin-mdx": "~3.6.2",
"eslint-plugin-react": "~7.37.5",
"eslint-plugin-react-hooks": "^5.2.0",
Expand Down
8 changes: 8 additions & 0 deletions apps/site/redirects.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,14 @@
{
"source": "/:locale/download/package-manager/all",
"destination": "/:locale/download/archive/current"
},
{
"source": "/404",
"destination": "/"
},
{
"source": "/500",
"destination": "/"
}
Comment on lines +355 to 362
Copy link
Member

@avivkeller avivkeller Nov 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan of having redirects on these error pages.

Comment on lines +355 to 362
Copy link

Copilot AI Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding redirects for /404 and /500 to / may not be the correct solution for the build error mentioned in the PR description. These status codes are typically meant to display error pages, not redirect to the homepage. This could mask actual 404/500 errors in production. Consider instead:

  1. Keeping proper 404 and 500 error pages
  2. Investigating why Next.js 16 is having issues with the _document module
  3. Checking if there are migration steps specific to error handling in Next.js 16
Suggested change
{
"source": "/404",
"destination": "/"
},
{
"source": "/500",
"destination": "/"
}

Copilot uses AI. Check for mistakes.
],
"internal": []
Expand Down
5 changes: 3 additions & 2 deletions apps/site/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"moduleResolution": "Bundler",
"resolveJsonModule": true,
"isolatedModules": true,
"jsx": "preserve",
"jsx": "react-jsx",
Copy link

Copilot AI Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JSX compiler option has been changed from "preserve" to "react-jsx". This change affects how JSX is transformed:

  • "preserve" keeps JSX as-is for Next.js to handle
  • "react-jsx" uses the automatic JSX runtime

While "react-jsx" is generally correct for React 17+, Next.js typically expects "preserve" so it can handle JSX transformation itself. This might cause build issues or unexpected behavior. Verify this change is necessary for Next.js 16, or consider reverting to "preserve".

Suggested change
"jsx": "react-jsx",
"jsx": "preserve",

Copilot uses AI. Check for mistakes.
"incremental": true,
"plugins": [
{
Expand All @@ -33,7 +33,8 @@
"**/*.tsx",
// Explicitly include since the globs won't match the `.`
".stylelintrc.mjs",
".next/types/**/*.ts"
".next/types/**/*.ts",
".next/dev/types/**/*.ts"
],
"exclude": ["node_modules", ".next"]
}
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,13 @@
"dependencies": {
"husky": "9.1.7",
"lint-staged": "16.2.3",
"turbo": "2.5.8"
"turbo": "2.6.1"
},
"devDependencies": {
"@eslint/js": "~9.36.0",
"@reporters/github": "^1.11.0",
"@testing-library/react": "~16.3.0",
"cross-env": "^10.0.0",
"cross-env": "^10.1.0",
"eslint": "~9.36.0",
"eslint-import-resolver-typescript": "~4.4.4",
"eslint-plugin-import-x": "~4.16.1",
Expand Down
Loading
Loading