-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add more unit tests #7371
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, but when you have some const or other thing and and expect
you need to add breakline to separate both thing
Can you reference what file you're talking about? Most of this was generated by Copilot. I checked the tests and seem good enough, are you talking about code styling? |
it('should return the initial state', () => { | ||
const initialState = releaseState; | ||
const action = { type: 'UNKNOWN_ACTION' }; | ||
expect(reducer(initialState, action)).toEqual(initialState); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expect(reducer(initialState, action)).toEqual(initialState); | |
expect(reducer(initialState, action)).toEqual(initialState); |
Here for example you can add on breakline it's will give some aire to the code. And that allow to see step on the test
- const
- run
- assert (expect)
This PR adds more unit tests covering functionality on
apps/site/util
,apps/site/reducers
andapps/site/providers