-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Removed and redirected how-to-install-nodejs to downloads page … #7283
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Note Your Pull Request seems to be updating Translations of the Node.js Website. Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only removing this content without adding a link in the first page seems to miss the spirit of #7184
Maybe we should just add a link to download at the bottom of the ‘introduction-to-nodejs’ page.
It also seems perhaps premature to remove this without thinking holistically about #7198 - it did predate our larger effort by 2 days.
Head branch was pushed to by a user without write access
yes sorry this was an oversight, added the link to the bottom, was not sure where it should of been placed or what specific format was wanted. |
apps/site/pages/en/learn/getting-started/introduction-to-nodejs.md
Outdated
Show resolved
Hide resolved
…s.md Co-authored-by: Augustin Mauroy <[email protected]> Signed-off-by: Brian Muenzenmeyer <[email protected]>
…(#7184)
Description
Removed directory and associated files for "how-to-install-NodeJS" and changed URL redirectory to the initial download page (https://nodejs.org/en/download/package-manager)
Validation
ran multiple checks on the URL
Related Issues
#7184
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.