Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Removed and redirected how-to-install-nodejs to downloads page … #7283

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

Bgregg93
Copy link
Contributor

…(#7184)

Description

Removed directory and associated files for "how-to-install-NodeJS" and changed URL redirectory to the initial download page (https://nodejs.org/en/download/package-manager)

Validation

ran multiple checks on the URL

Related Issues

#7184

Check List

  • [ x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [ x] I have run npm run format to ensure the code follows the style guide.
  • [ x] I have run npm run test to check if all tests are passing.
  • [x ] I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Bgregg93 Bgregg93 requested review from a team as code owners November 26, 2024 02:16
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 20, 2024 4:52am

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

apps/site/navigation.json Show resolved Hide resolved
Copy link
Contributor

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

Copy link
Member

@benhalverson benhalverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rad LGTM

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only removing this content without adding a link in the first page seems to miss the spirit of #7184

Maybe we should just add a link to download at the bottom of the ‘introduction-to-nodejs’ page.

It also seems perhaps premature to remove this without thinking holistically about #7198 - it did predate our larger effort by 2 days.

auto-merge was automatically disabled November 28, 2024 22:12

Head branch was pushed to by a user without write access

@Bgregg93
Copy link
Contributor Author

Only removing this content without adding a link in the first page seems to miss the spirit of #7184

yes sorry this was an oversight, added the link to the bottom, was not sure where it should of been placed or what specific format was wanted.

Copy link
Contributor

github-actions bot commented Nov 29, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.5% (591/653) 76.06% (178/234) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
132 0 💤 0 ❌ 0 🔥 5.165s ⏱️

…s.md

Co-authored-by: Augustin Mauroy <[email protected]>
Signed-off-by: Brian Muenzenmeyer <[email protected]>
@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Dec 20, 2024
Merged via the queue into nodejs:main with commit 53ce0b3 Dec 20, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants