net: always publish to 'net.client.socket' diagnostics channel #58349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the 'net.client.socket' diagnostics channel was only published to when `net.connect()` was called. This change ensures the message is also published for the following calls: - net.createConnection() - net.Socket#connect() - tls.connect() Signed-off-by: Darshan Sen <[email protected]>
|
Review requested:
|
nodejs-github-bot
added
needs-ci
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
May 16, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58349 +/- ##
=======================================
Coverage 90.23% 90.23%
=======================================
Files 633 633
Lines 186818 186839 +21
Branches 36668 36682 +14
=======================================
+ Hits 168578 168598 +20
- Misses 11036 11038 +2
+ Partials 7204 7203 -1
🚀 New features to boost your workflow:
|
theanarkh
approved these changes
May 16, 2025
RaisinTen
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9eb9c26 |
RaisinTen
deleted the
net-always-publish-to-net.client.socket-diagnostics-channel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the 'net.client.socket' diagnostics channel was only published to when
net.connect()was called. This change ensures the message is also published for the following calls:net.createConnection()net.Socket#connect()tls.connect()