fs: unexpose internal constants #58327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
approved these changes
May 14, 2025
`EXTENSIONLESS_FORMAT_JAVASCRIPT` and `EXTENSIONLESS_FORMAT_WASM` are only used internally through binding `getFormatOfExtensionlessFile`. They should not be exposed publicly.
legendecas
force-pushed
the
constants/internal
branch
from
2d1466f to
e228d6f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58327 +/- ##
==========================================
- Coverage 90.23% 90.23% -0.01%
==========================================
Files 633 633
Lines 186818 186827 +9
Branches 36668 36668
==========================================
+ Hits 168578 168584 +6
+ Misses 11036 11035 -1
- Partials 7204 7208 +4
🚀 New features to boost your workflow:
|
github-actions
bot
added
request-ci-failed
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - fs: unexpose internal constants ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/15045856908 |
legendecas
removed
the
request-ci-failed
LiviaMedeiros
approved these changes
May 15, 2025
|
is this a breaking change, then? |
I think breaking an undocumented feature is not considered a semver-major change as long as it doesn't affect the ecosystem. We can decide to not land it on LTS just to be sure – another approach that would limit the number of conflicts would be to land a first iteration moving them to that new |
|
These two undocumented constants are not used in any public APIs. Their values are just 0 and 1. I don't think the two constants can be used in any meaningful way. |
jsumners-nr
approved these changes
May 16, 2025
juanarbol
approved these changes
May 16, 2025
juanarbol
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a436f7b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXTENSIONLESS_FORMAT_JAVASCRIPTandEXTENSIONLESS_FORMAT_WASMareonly used internally through binding
getFormatOfExtensionlessFile.They should not be exposed publicly.
Add a test to cover public
fs.constantsto avoid unexpected keys.