Skip to content

http2: deprecate priority #58313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

mcollina
Copy link
Member

Ref #58293
and #57269.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels May 13, 2025
@mcollina mcollina added lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x and removed doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels May 13, 2025
@marco-ippolito
Copy link
Member

We might have to create an entry in the deprecation.md

@aduh95
Copy link
Contributor

aduh95 commented May 16, 2025

The subsystem should be doc:, not http2

@aduh95 aduh95 added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. deprecations Issues and PRs related to deprecations. labels May 16, 2025
@aduh95 aduh95 force-pushed the deprecate-http2-priority branch from 9c14a3f to 5fb3871 Compare May 28, 2025 23:08
description: Documentation-only deprecation.
-->

Type: Documentation-only
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Honestly, I'd be fine with going straight to a Runtime deprecation.

@aduh95 aduh95 force-pushed the deprecate-http2-priority branch from 5fb3871 to 3ba178c Compare May 28, 2025 23:11
@aduh95 aduh95 requested a review from pimterry May 28, 2025 23:12
Signed-off-by: Matteo Collina <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
@aduh95 aduh95 force-pushed the deprecate-http2-priority branch from 3ba178c to b01bc60 Compare May 28, 2025 23:14
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2025
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2025
@nodejs-github-bot nodejs-github-bot merged commit 41ab185 into nodejs:main May 29, 2025
22 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 41ab185

@aduh95 aduh95 added the notable-change PRs with changes that should be highlighted in changelogs. label May 29, 2025
Copy link
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @aduh95.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. lts-watch-v20.x PRs that may need to be released in v20.x lts-watch-v22.x PRs that may need to be released in v22.x notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants