Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update test-child-process-windows-hide to use node:test #56437

Merged
merged 1 commit into from
Jan 4, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 23 additions & 24 deletions test/parallel/test-child-process-windows-hide.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,49 +3,48 @@
const common = require('../common');
const assert = require('assert');
const cp = require('child_process');
const { test } = require('node:test');
const internalCp = require('internal/child_process');
const cmd = process.execPath;
const args = ['-p', '42'];
const options = { windowsHide: true };

// Since windowsHide isn't really observable, monkey patch spawn() and
// spawnSync() to verify that the flag is being passed through correctly.
const originalSpawn = internalCp.ChildProcess.prototype.spawn;
const originalSpawnSync = internalCp.spawnSync;
// Since windowsHide isn't really observable, this test relies on monkey
// patching spawn() and spawnSync() to verify that the flag is being passed
// through correctly.

internalCp.ChildProcess.prototype.spawn = common.mustCall(function(options) {
assert.strictEqual(options.windowsHide, true);
return originalSpawn.apply(this, arguments);
}, 2);

internalCp.spawnSync = common.mustCall(function(options) {
assert.strictEqual(options.windowsHide, true);
return originalSpawnSync.apply(this, arguments);
});

{
test('spawnSync() passes windowsHide correctly', (t) => {
const spy = t.mock.method(internalCp, 'spawnSync');
const child = cp.spawnSync(cmd, args, options);

assert.strictEqual(child.status, 0);
assert.strictEqual(child.signal, null);
assert.strictEqual(child.stdout.toString().trim(), '42');
assert.strictEqual(child.stderr.toString().trim(), '');
}
assert.strictEqual(spy.mock.calls.length, 1);
assert.strictEqual(spy.mock.calls[0].arguments[0].windowsHide, true);
});

{
test('spawn() passes windowsHide correctly', (t, done) => {
const spy = t.mock.method(internalCp.ChildProcess.prototype, 'spawn');
const child = cp.spawn(cmd, args, options);

child.on('exit', common.mustCall((code, signal) => {
assert.strictEqual(code, 0);
assert.strictEqual(signal, null);
assert.strictEqual(spy.mock.calls.length, 1);
assert.strictEqual(spy.mock.calls[0].arguments[0].windowsHide, true);
done();
}));
}
});

{
const callback = common.mustSucceed((stdout, stderr) => {
test('execFile() passes windowsHide correctly', (t, done) => {
const spy = t.mock.method(internalCp.ChildProcess.prototype, 'spawn');
cp.execFile(cmd, args, options, common.mustSucceed((stdout, stderr) => {
assert.strictEqual(stdout.trim(), '42');
assert.strictEqual(stderr.trim(), '');
});

cp.execFile(cmd, args, options, callback);
}
assert.strictEqual(spy.mock.calls.length, 1);
assert.strictEqual(spy.mock.calls[0].arguments[0].windowsHide, true);
done();
}));
});
Loading