Skip to content

Nominating @jonasba to be a collaborator #57410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anonrig opened this issue Mar 11, 2025 · 7 comments · Fixed by #58355
Closed

Nominating @jonasba to be a collaborator #57410

anonrig opened this issue Mar 11, 2025 · 7 comments · Fixed by #58355
Labels
meta Issues and PRs related to the general management of the project.

Comments

@anonrig
Copy link
Member

anonrig commented Mar 11, 2025

Jonas was a colleague (and a friend) of mine from Sentry, and I was tracking his contributions in the past couple of months and saw that he's made some great and stable contributions in both javascript and c++ to Node.js. He has landed his first commit almost 8 months ago, and I know that he's working on couple of more.

I think it would be fair to say that he is a great candidate for node.js collaborator. I can vouch for him personally. The contributions (both landed and closed PRs) speak for themselves.

Commits authored on nodejs/node: github.com/nodejs/node/commits?author=jonasba
Pull requests opened: github.com/search?q=author:jonasba+org:nodejs&type=pullrequests
Issues opened: github.com/search?q=author:jonasba+org:nodejs&type=issues
Comments on pull requests and issues throughout the Node.js organization: https://github.com/search?q=commenter%3Ajonasba+org%3Anodejs&type=pullrequests

cc @nodejs/collaborators @nodejs/tsc

@jasnell
Copy link
Member

jasnell commented Mar 11, 2025

Sgtm

@RaisinTen
Copy link
Member

+1

@mcollina
Copy link
Member

Sgtm

@anonrig
Copy link
Member Author

anonrig commented Apr 30, 2025

It's been more than seven days, which means this nomination has passed, congrats! @JonasBa can you confirm publicly that you're interested? If so, let's schedule an onboarding.

@RaisinTen RaisinTen added the meta Issues and PRs related to the general management of the project. label May 1, 2025
@mhdawson
Copy link
Member

mhdawson commented May 1, 2025

Belated +1 from me

@JonasBa
Copy link
Contributor

JonasBa commented May 1, 2025

It's been more than seven days, which means this nomination has passed, congrats! @JonasBa can you confirm publicly that you're interested? If so, let's schedule an onboarding.

Yes, I'd be honored to contribute, and look forward to doing so more often :)!

@anonrig
Copy link
Member Author

anonrig commented May 1, 2025

It's been more than seven days, which means this nomination has passed, congrats! @JonasBa can you confirm publicly that you're interested? If so, let's schedule an onboarding.

Yes, I'd be honored to contribute, and look forward to doing so more often :)!

That’s perfect news. I’ll schedule an onboarding session with you soon.

JonasBa added a commit to JonasBa/node that referenced this issue May 16, 2025
JonasBa added a commit to JonasBa/node that referenced this issue May 16, 2025
nodejs-github-bot pushed a commit that referenced this issue May 16, 2025
Fixes: #57410
PR-URL: #58355
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
aduh95 pushed a commit that referenced this issue May 20, 2025
Fixes: #57410
PR-URL: #58355
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants