-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
Nominating @jonasba to be a collaborator #57410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sgtm |
+1 |
Sgtm |
It's been more than seven days, which means this nomination has passed, congrats! @JonasBa can you confirm publicly that you're interested? If so, let's schedule an onboarding. |
Belated +1 from me |
Yes, I'd be honored to contribute, and look forward to doing so more often :)! |
That’s perfect news. I’ll schedule an onboarding session with you soon. |
Fixes: #57410 PR-URL: #58355 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Fixes: #57410 PR-URL: #58355 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Jonas was a colleague (and a friend) of mine from Sentry, and I was tracking his contributions in the past couple of months and saw that he's made some great and stable contributions in both javascript and c++ to Node.js. He has landed his first commit almost 8 months ago, and I know that he's working on couple of more.
I think it would be fair to say that he is a great candidate for node.js collaborator. I can vouch for him personally. The contributions (both landed and closed PRs) speak for themselves.
Commits authored on nodejs/node: github.com/nodejs/node/commits?author=jonasba
Pull requests opened: github.com/search?q=author:jonasba+org:nodejs&type=pullrequests
Issues opened: github.com/search?q=author:jonasba+org:nodejs&type=issues
Comments on pull requests and issues throughout the Node.js organization: https://github.com/search?q=commenter%3Ajonasba+org%3Anodejs&type=pullrequests
cc @nodejs/collaborators @nodejs/tsc
The text was updated successfully, but these errors were encountered: