Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add expected assets for v24 #4057

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS
Copy link
Member Author

I see we have removed the ppc 32 bits, but it looks like it wasn't in the v23.x expected assets either, so I assume that's correct.

@richardlau
Copy link
Member

I see we have removed the ppc 32 bits, but it looks like it wasn't in the v23.x expected assets either, so I assume that's correct.

I'm confused, we've never produced 32-bit ppc binaries for Node.js.

@richardlau
Copy link
Member

I see we have removed the ppc 32 bits, but it looks like it wasn't in the v23.x expected assets either, so I assume that's correct.

I'm confused, we've never produced 32-bit ppc binaries for Node.js.

ah you're referring to nodejs/node@44b0e423dc. That's just a tidy up. As mentioned, we've never produced binaries for that, but a long time ago you could build that configuration from source.

@RafaelGSS
Copy link
Member Author

Yes, that's exactly what I was talking about. Thanks for the clarification.

@richardlau richardlau merged commit ab90cb5 into main Apr 10, 2025
4 checks passed
@richardlau richardlau deleted the add-v24-expected-assets branch April 10, 2025 15:11
@richardlau
Copy link
Member

I've added the new expected assets file to the www server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants